Closed
Bug 1368416
Opened 7 years ago
Closed 7 years ago
TestNamedPipeService.cpp includes case-sensitive Windows.h on MinGW (which cannot be found)
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor][necko-active])
Attachments
(1 file)
The correct include for MinGW is windows.h. Fortunately, Windows is case-insensitive, so this is safe to take for Windows too.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•7 years ago
|
Attachment #8872249 -
Flags: review?(mcmanus)
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8872249 [details] Bug 1368416 Include 'windows.h' instead of 'Windows.h' for MinGW support https://reviewboard.mozilla.org/r/143740/#review152736
Attachment #8872249 -
Flags: review?(mcmanus) → review+
|
||
Updated•7 years ago
|
Whiteboard: [tor] → [tor][necko-active]
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/511a8734028f Include 'windows.h' instead of 'Windows.h' for MinGW support r=mcmanus
Keywords: checkin-needed
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/511a8734028f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•