1368418 - Remove some unused i18n modules

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1368418 part 1 - Remove nsISemanticUnitScanner.

Code search indicates that this is not used internally, and the only
addon uses this is Breadcrumbs, which hasn't been updated since 2009,
thus it is already not compatible with current Firefox.

Review commit: https://reviewboard.mozilla.org/r/143744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143744/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1368418 part 2 - Remove nsCaseConversionImp2.

Code search indicates that it is used neither internally nor in any
addon. It should be safe to remove.

Review commit: https://reviewboard.mozilla.org/r/143746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143746/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1368418 part 3 - Remove nsCategoryImp.

Review commit: https://reviewboard.mozilla.org/r/143748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143748/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143748/diff/1-2/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872252 [details]
Bug 1368418 part 1 - Remove nsISemanticUnitScanner.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143744/diff/1-2/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872253 [details]
Bug 1368418 part 2 - Remove nsCaseConversionImp2.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143746/diff/1-2/

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143748/diff/2-3/

Comment 8

[Masatoshi Kimura [:emk]]

Comment on attachment 8872252 [details]
Bug 1368418 part 1 - Remove nsISemanticUnitScanner.

https://reviewboard.mozilla.org/r/143744/#review147682

Comment 9

[Masatoshi Kimura [:emk]]

Comment on attachment 8872253 [details]
Bug 1368418 part 2 - Remove nsCaseConversionImp2.

https://reviewboard.mozilla.org/r/143746/#review147684

Comment 10

[Masatoshi Kimura [:emk]]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

https://reviewboard.mozilla.org/r/143748/#review147686

::: commit-message-dbcdc:1
(Diff revision 3)
> +Bug 1368418 part 3 - Remove nsCategoryImp. r?emk

Who is implementing nsIUGenCategory after this removal? If nobody is, could you de-COM nsIUGenCategory? (for example, make nsUGenCategory an independent scoped-enum and remove everything else)

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143748/diff/3-4/

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143748/diff/4-5/

Comment 13

[Masatoshi Kimura [:emk]]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

https://reviewboard.mozilla.org/r/143748/#review147736

::: intl/unicharutil/nsUGenCategory.h:7
(Diff revision 5)
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef nsUGenCategory_h__

nit: please do not include double underscore in C++ identifiers.

Comment 14

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143748/diff/5-6/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c14a7823ce37
part 1 - Remove nsISemanticUnitScanner. r=emk
https://hg.mozilla.org/integration/autoland/rev/bb587e11b75f
part 2 - Remove nsCaseConversionImp2. r=emk
https://hg.mozilla.org/integration/autoland/rev/2f09a955dbd6
part 3 - Remove nsCategoryImp. r=emk

Comment 16

[Jorg K (CEST = GMT+2)]

Actually, we used the NS_SEMANTICUNITSCANNER_CONTRACTID here:
https://dxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#769

Comment 17

[Jorg K (CEST = GMT+2)]

And it looks like we really need it there :-(

Comment 18

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Jorg K (GMT+2) from comment #16)
> Actually, we used the NS_SEMANTICUNITSCANNER_CONTRACTID here:
> https://dxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-
> spam-filter/src/nsBayesianFilter.cpp#769

Sorry about that. I didn't know that comm-central may also need that.

Could you port nsISemanticUnitScanner to comm-central, or if it is non-trivial, probably we can backout part 1?

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c14a7823ce37
https://hg.mozilla.org/mozilla-central/rev/bb587e11b75f
https://hg.mozilla.org/mozilla-central/rev/2f09a955dbd6