Closed
Bug 1368418
Opened 7 years ago
Closed 7 years ago
Remove some unused i18n modules
Categories
(Core :: Internationalization, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(3 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8872252 [details]
Bug 1368418 part 1 - Remove nsISemanticUnitScanner.
https://reviewboard.mozilla.org/r/143744/#review147682
Attachment #8872252 -
Flags: review?(VYV03354) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8872253 [details]
Bug 1368418 part 2 - Remove nsCaseConversionImp2.
https://reviewboard.mozilla.org/r/143746/#review147684
Attachment #8872253 -
Flags: review?(VYV03354) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.
https://reviewboard.mozilla.org/r/143748/#review147686
::: commit-message-dbcdc:1
(Diff revision 3)
> +Bug 1368418 part 3 - Remove nsCategoryImp. r?emk
Who is implementing nsIUGenCategory after this removal? If nobody is, could you de-COM nsIUGenCategory? (for example, make nsUGenCategory an independent scoped-enum and remove everything else)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 13•7 years ago
|
||
mozreview-review |
Comment on attachment 8872254 [details]
Bug 1368418 part 3 - Remove nsCategoryImp.
https://reviewboard.mozilla.org/r/143748/#review147736
::: intl/unicharutil/nsUGenCategory.h:7
(Diff revision 5)
> +/* vim: set ts=8 sts=2 et sw=2 tw=80: */
> +/* This Source Code Form is subject to the terms of the Mozilla Public
> + * License, v. 2.0. If a copy of the MPL was not distributed with this
> + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> +
> +#ifndef nsUGenCategory_h__
nit: please do not include double underscore in C++ identifiers.
Attachment #8872254 -
Flags: review?(VYV03354) → review+
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c14a7823ce37
part 1 - Remove nsISemanticUnitScanner. r=emk
https://hg.mozilla.org/integration/autoland/rev/bb587e11b75f
part 2 - Remove nsCaseConversionImp2. r=emk
https://hg.mozilla.org/integration/autoland/rev/2f09a955dbd6
part 3 - Remove nsCategoryImp. r=emk
Comment 16•7 years ago
|
||
Actually, we used the NS_SEMANTICUNITSCANNER_CONTRACTID here:
https://dxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp#769
Comment 17•7 years ago
|
||
And it looks like we really need it there :-(
Assignee | ||
Comment 18•7 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #16)
> Actually, we used the NS_SEMANTICUNITSCANNER_CONTRACTID here:
> https://dxr.mozilla.org/comm-central/source/mailnews/extensions/bayesian-
> spam-filter/src/nsBayesianFilter.cpp#769
Sorry about that. I didn't know that comm-central may also need that.
Could you port nsISemanticUnitScanner to comm-central, or if it is non-trivial, probably we can backout part 1?
Comment 19•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c14a7823ce37
https://hg.mozilla.org/mozilla-central/rev/bb587e11b75f
https://hg.mozilla.org/mozilla-central/rev/2f09a955dbd6
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•