1368448 - Intermittent dom/media/test/test_bug1113600.html | application terminated with exit code -139

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/logviewer.html#?job_id=102779900&repo=try

GECKO(1637) | Assertion failure: IsAcquired() && mOwningThread == PR_GetCurrentThread(), at /home/worker/workspace/build/src/xpcom/threads/BlockingResourceBase.cpp:399 [log…] 

called from #01: mozilla::MediaStreamGraphImpl::AudioTrackPresent [dom/media/MediaStreamGraph.cpp:506]

Comment 1

[Andreas Pehrson [:pehrsons]]

The relevant piece of stack:
> [task 2017-05-29T09:26:48.399664Z] 09:26:48     INFO - GECKO(1637) | #01: mozilla::MediaStreamGraphImpl::AudioTrackPresent [dom/media/MediaStreamGraph.cpp:506]
> [task 2017-05-29T09:26:48.401378Z] 09:26:48     INFO - GECKO(1637) | #02: mozilla::AudioCallbackDriver::Init [dom/media/GraphDriver.cpp:734]
> [task 2017-05-29T09:26:48.402584Z] 09:26:48     INFO - GECKO(1637) | #03: mozilla::AsyncCubebTask::Run [dom/media/GraphDriver.cpp:522]

Somehow MSGImpl::mDriver::OnThread() returns false when an AsyncCubebTask runs for an AudioCallbackDriver.

Alex, do you know how the threading here should work?

Comment 2

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=121c4a02a48c

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1368448 - After full duplex AEC info can be found in MSG.

Review commit: https://reviewboard.mozilla.org/r/146126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146126/

Comment 4

[Paul Adenot (:padenot)]

Comment on attachment 8874755 [details]
Bug 1368448 - After full duplex AEC info can be found in MSG.

https://reviewboard.mozilla.org/r/146126/#review150084

::: commit-message-2029b:1
(Diff revision 1)
> +Bug 1368448 - After full duplex AEC info can be found in MSG. r?padenot

It'd rephrase this as:

    Stop using a render-thread-only method when initializing a new AudioCallbackDriver.

so the fix is better conveyed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f42d4d3ef2
After full duplex AEC info can be found in MSG. r=padenot

Comment 6

[Alex Chronopoulos [:achronop]]

Ooops I'm afraid I missed the comment ...

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/34f42d4d3ef2