1368464 - MJPEG (multipart/x-mixed-replace): Cannot paste to other application after copying image. The other application hangs up. Browser crashes after quit browser

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

+++ This bug was initially created as a clone of Bug #1368288 +++

Steps to reproduce:
1. Visit any page that contains a MJPEG image stream.
    Example: http://www.northeastern.edu/webcams/foodcourt.html
2. right-clicking > Copy Image>
3. Attempt to paste to paint.net and wordpad

Actual results:
The other application hangs up until browser quit.
And Browser get crash bp-4d9c30ed-537d-4b7c-b606-491730170528 after quit browser.



Expected results:

Current frame of mJPEG should be pasting with out no hange and crash


Regression window:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=46045ec8a4aa09a341b7209170089ade3c27c1a5&tochange=71c8d652e638dd67c5c56879df83d76b30033458

Regressed by: Bug 664717

Comment 1

[Alice0775 White]

Via local build
Last Good: 466c454e0393
First Bad: 457ebb2b73ad

Regressed by: 457ebb2b73ad	Hector Zhao — Bug 664717 - Part 3: Include file promise when copying an image in Windows. r=seth

Comment 2

[Hector Zhao [:hectorz]]

Attachment: Bug 1368464 - don't attempt to copy multipart image as file promise.

Review commit: https://reviewboard.mozilla.org/r/145712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145712/

Comment 3

[Hector Zhao [:hectorz]]

IIUC, since MJPEG is actually a stream, I should not be trying to copy it into Windows clipboard as a file (promise).

I don't know if there're any other image formats that should be excluded, though.

Comment 4

[Timothy Nikkel (:tnikkel)]

Comment on attachment 8874348 [details]
Bug 1368464 - don't attempt to copy multipart image as file promise.

https://reviewboard.mozilla.org/r/145712/#review149642

Comment 5

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f6a5a8ae99bd48a196330b88f91e372581716ba7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5176b6015527
Don't attempt to copy multipart image as file promise. r=tnikkel

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5176b6015527

Comment 8

[Ryan VanderMeulen [:RyanVM]]

This already missed 54 and it doesn't look severe enough to worry about backporting to ESR52 either. Feel free to set the status back to affected and nominate it for approval if you feel otherwise, however.

Comment 9

[Yanfang Liu]

Verified fixed!