1368615 - Hard to understand flag requestee with only email address visible

Status: NEW

(bugzilla.mozilla.org :: User Interface, defect, P3)

Description

[Frederik Braun [:freddy]]

Whenever a comment shows that a flag was requested to someone, it shows the e-mail address.
This is problematic, as it hides which user name (real name, nickname) is behind that email address. Especially when people do not their flastname@mozilla address (which I think is a fine thing, btw!).

It would be nice if it could default to something more human readable, e.g.,
> needinfo?(Frederik Braun [:freddyb])
It could still show the email-address as a hover text with a title element.

If this change is too risky, I would accept showing the email and putting the name in the title :-)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

The problem is that the history is not normalized. The needinfo?(foo) is stored as a string in the db, and emails can change at any time. It's not impossible to fix this... going back to about 2014 we have a table that *does* contain all the flag history information we could want... I think my preferred solution would be...


1) Add a nullable requestee_id column to bugs_activity, and a nullable boolean requestee_id_guess
2) backfill as much as possible with flag_state_activity, with requestee_id_guess set to false
3) Anything not backfilled, if the email listed in the parens still exists, use that value and set requestee_id_guess to true.
4) In the UI: Parse $FLAG?($ARG). If the requestee_id column is defined, replace $ARG with User->new(requestee_id)->identity.
Extra: if requestee_id_guess is true, bubble up a hint to the UI that this might be incorrect.
A small superscripted [?] with a link explaining that history is fuzzy should suffice.

Comment 2

[Frederik Braun [:freddy]]

(In reply to Dylan Hardison [:dylan] (he/him) from comment #1)
> The problem is that the history is not normalized. The needinfo?(foo) is
> stored as a string in the db, and emails can change at any time. It's not
> impossible to fix this... 

Heh, that invalidates my assumption about this being an easy fix :)