Closed Bug 1368662 Opened 5 years ago Closed 5 years ago

Better fix for bug 1345898

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jya, Assigned: jya)

Details

Attachments

(1 file)

In bug 1345898, we flush rather than drain while we're in waiting_for_data mode, but it also happens that really we're in the middle of an internal seek.

It makes much more logical sense to rely on internal seek instead as this is the actual reason we don't care of the frames coming out
Assignee: nobody → jyavenard
Comment on attachment 8872592 [details]
Bug 1368662: Better fix for bug 1345898.

https://reviewboard.mozilla.org/r/144132/#review147848

r+ with a proper commit message.

::: commit-message-af918:1
(Diff revision 1)
> +Bug 1368662: Better fix for bug 1345898. r?gerald

I'd like a proper commit message (i.e., what you're doing in the first line, and why&how below)
Attachment #8872592 - Flags: review?(gsquelart) → review+
https://hg.mozilla.org/mozilla-central/rev/fcf2ffca171f
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.