uncaught rejected promises in EventTooltipHelper.js

RESOLVED FIXED in Firefox 55

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: tromey, Assigned: tromey)

Tracking

Trunk
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
I saw some try runs with this error in the logs:

[task 2017-05-30T13:09:56.210781Z] 13:09:56     INFO - Console message: [JavaScript Error: "TypeError: this._tooltip is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/widgets/tooltip/EventTooltipHelper.js" line: 123}]
[task 2017-05-30T13:09:56.231376Z] 13:09:56     INFO - GECKO(1133) | JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/widgets/tooltip/EventTooltipHelper.js, line 123: TypeError: this._tooltip is null

This comes from the patch in bug 1333352.
Presumably what happens is that the tooltip is destroyed before the
service answers.
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Blocks: 1366853

Comment 2

2 years ago
mozreview-review
Comment on attachment 8872635 [details]
Bug 1368695 - don't emit event when tooltip already destroyed;

https://reviewboard.mozilla.org/r/144180/#review148702

Thanks for the patch Tom!
Attachment #8872635 - Flags: review?(jdescottes) → review+

Comment 3

2 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21e673ba5a16
don't emit event when tooltip already destroyed; r=jdescottes

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/21e673ba5a16
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.