1368695 - uncaught rejected promises in EventTooltipHelper.js

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P1)

Description

[Tom Tromey :tromey]

I saw some try runs with this error in the logs:

[task 2017-05-30T13:09:56.210781Z] 13:09:56     INFO - Console message: [JavaScript Error: "TypeError: this._tooltip is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/widgets/tooltip/EventTooltipHelper.js" line: 123}]
[task 2017-05-30T13:09:56.231376Z] 13:09:56     INFO - GECKO(1133) | JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/shared/widgets/tooltip/EventTooltipHelper.js, line 123: TypeError: this._tooltip is null

This comes from the patch in bug 1333352.
Presumably what happens is that the tooltip is destroyed before the
service answers.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1368695 - don't emit event when tooltip already destroyed;

If a reply comes from source-map-url-service but the tooltip has already
been destroyed, don't try to emit the event-tooltip-source-map-ready
event.

Review commit: https://reviewboard.mozilla.org/r/144180/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144180/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8872635 [details]
Bug 1368695 - don't emit event when tooltip already destroyed;

https://reviewboard.mozilla.org/r/144180/#review148702

Thanks for the patch Tom!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21e673ba5a16
don't emit event when tooltip already destroyed; r=jdescottes

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21e673ba5a16