13687 - nsHTMLEditor::OutputToString called many times on startup

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Akkana Peck]

On startup, nsHTMLEditor::OutputToString is called 12 (more or less) times.
(Bruce noticed this because a small leak in the XIF converter showed very
prominently in Purify logs.)  This seems like a performance hit, since all of
these have to go through the parser twice (and there are some known performance
problems in the parsing process).

Most of these calls are coming via
nsGfxTextControlFrame::InternalContentChanged, presumably from the URL bar
(since that's the only text field actually showing in the default browser
window).

Comment 1

[buster]

simple performance work set to M12

Comment 2

[leger]

Putting on [Perf] radar.

Comment 3

[Akkana Peck]

This function also gets called every time the mouse enters (or moves over?) any
part of the browser window (not just over the text field itself).

Comment 4

[buster]

I'll jump on this early in M12. I can do some smart caching, I'm sure.

Comment 5

[buster]

mostly fixed.  still needs some data, but I think I got rid of most of the
noise.  Reducing the priority and severity since it's mostly if not completely
fixed.

Comment 6

[lchiang]

beppe asked suresh to help with doing a purify run on this to confirm.  buster,
akkana, can we just bring up the Editor under Tasks in 5.0 and close the window?
Then, we'd take the Win32 Purify log resulting from that and attach to this bug
report for you to review.  Thanks.

Comment 7

[Akkana Peck]

Lisa: the editor window won't show this, because it doesn't have any text fields
in it.  Try the browser window (url bar) and the mail compose window (addressing
field).

I'm still seeing this function called every time I enter the mail compose window
(I haven't tested the browser window/url bar recently).  It's only called once
per enter event, though, not multiple times.

Comment 8

[lchiang]

We'll do this with M12 tip builds:
1.  Start Seamonkey into the browser window.
2.  Place the mouse into the URL field and go to bugzilla.mozilla.org
3.  Exit Seamonkey
-->Capture log 1

1.  Start Seamonkey into Mail
2.  Compose a new message - html compose window
3.  Place the cursor into the addressing field and enter some text
4.  Close the compose window
5.  Exit Seamonkey
--> Capture log

Comment 9

[Akkana Peck]

Don't forget to move the mouse in and out of the window (the whole window, not
just the text field) several times, since that calls the function again.

Note that the original bug wasn't on a leak, it was on a performance problem
(the fact that text fields call the parser too often).  I certainly don't want
to discourage anyone from running purify since that's always a worthwhile thing
to do, but quantify data might be more on target for addressing whether this is
still a performance problem.

Comment 10

[lchiang]

Ok. Beth told me Purify.  If Suresh has Quantify set up, he can do this also.

Comment 11

[Suresh]

I will run purify and attach 2 logs as per Lisa's comments at 14:52.
I will also post a Quantify data ASAP. Thanks.

Comment 12

[Suresh]

I have posted 2 Purify logs at http://jazz/users/suresh/publish/bug13687/.
Both the logs are as per Lisa's comment on 11/12/99 14:52 plus moving mouse in
and out of the whole window.
I will try to post the Quantify data ASAP. (I have some license key issues with
Quantify Software. :-(   )

Comment 13

[buster]

still waiting for quantify data....
moved to M13.

Comment 14

[Suresh]

Sorry about the delay. Rational Software never replied back to me. Will call
them again today.

Comment 15

[buster]

I believe this is now fixed.
The way to test this is to run quantify and see how frequently
nsHTMLEditor::OutputToString is called.  You will need a a couple of test cases:
one that has just a text control, one that has just a text area, and one that
has a large number of both (maybe 20 of each.)  Run viewer under quantify for
each, and you should see a very small number of calls to
nsHTMLEditor::OutputToString.  Resize the windows, do mouse overs, etc.  The
counts shouldn't go very high.  If you have any questions about whether you're
getting a reasonable number of counts, contact me and we'll discuss it.

Comment 16

[Paul MacQuiddy]

Suresh, can you look at this?

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

This seems fixed to me.  I tried Buster's testcase and I'll attach a 
screenshot, sorted by function call of the Quantify output gathered running 
under Windows 2000 with a current trunk build of viewer.exe.

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Screenshot of Quantify output

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

Verified fixed (If I'm going about this wrong, let me know).

Comment 20

[Suresh]

Thanks Stephend!