1368724 - [Shield] Handle the error in the cases where the Pref. Experiment is aborted

Status: RESOLVED FIXED

(Shield :: General, defect)

Description

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

[Preconditions:]
1. Obtain a copy of Firefox with the SHIELD recipe client system add-on installed. You can check about:support to ensure that you have it.
2. Set the extensions.shield-recipe-client.dev_mode preference to true to run recipes immediately on startup.
3. Set the extensions.shield-recipe-client.logging.level preference to 0 to enable more logging.
4. Set the security.content.signature.root_hash preference to DB:74:CE:58:E4:F9:D0:9E:E0:42:36:BE:6C:C5:C4:F6:6A:E7:74:7D:C0:21:42:7A:03:BC:2F:57:0C:8B:9B:90.
5. Set the preference value for extensions.shield-recipe-client.api_url set to https://normandy.stage.mozaws.net/api/v1

[Steps:]
1. Create an Pref. Experiment recipe.
2. Approve it/Enable it and run it on a FF client.
3. Clone to above recipe, changing the slug and targeting the same users as the recipe from step1.
4. Restart FF client -> triggers run for the recipe no. 2

[Actual Result:]
https://pastebin.mozilla.org/9023077


[Expected Result:]
As per discussing this with :osmose, this is the expected result, therefore the log should be handled, a warning given instead of an Error type message.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/normandy

https://github.com/mozilla/normandy/commit/514c9308346f8b28ab2ae59db2d9ab6810487d3e
Fix bug 1368724: Warn and abort before starting a conflicting pref-exp.

Previously, we'd call `start` regardless, which throws an error for
experiments whose preference conflicts with active experiment.