1368764 - Component watching relationship constant not exported in template constants

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect, P1)

Description

[Karl Thiessen [:kthiessen, he/him]]

Excerpt from email from Comment # 35 on Bug 949655 from Byron Jones ‹:glob› at 2017-05-30 06:37:31 PDT:

<div id=3D"reason" style=3D"font-size: 90%; color: #666666">
    <hr style=3D"border: 1px dashed #969696">
    <b>You are receiving this mail because:</b>
    <ul>
          <li>You are watching the component for the bug.</li>
    </ul>
  </div>

Excerpt from email from Comment # 36 on Bug 949655 from neekbeta at 2017-05-30 07:52:04 PDT:

<div id=3D"reason" style=3D"font-size: 90%; color: #666666">
    <hr style=3D"border: 1px dashed #969696">
    <b>You are receiving this mail because:</b>
    <ul>
    </ul>
  </div>

Please note that in both emails the "X-Bugzilla-Watch-Reason: Component-Watcher" header is correctly present.

More details available on request, but I hope this is enough to start with.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

This is because of bug 1352264. It's not enough to make 'constants' a variable, we must also set CONSTANT_NAMESPACE to something else -- else the template compiler gets confused and does constant folding.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

To github.com:mozilla-bteam/bmo.git
   82ea853bd..316a5ce16  master -> master

Comment 3

[Dylan Hardison [:dylan] (he/him)]

It seems this fixed some cases of the bug, but not others.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1368764_1.patch

Because of constant folding, we moved the 'constants' to the VARIABLES hash (see in Bugzilla/Template.pm) but did not update the extensions using this.

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8872853 [details] [diff] [review]
1368764_1.patch

I think sebastin is a bit busy, asking atoll so I can get this out next week.

Comment 6

[:Atoll]

Comment on attachment 8872853 [details] [diff] [review]
1368764_1.patch

This is valid Perl, and the change is applied to three places correctly. r+, two assumptions: the string 'CONSTANTS' is either absent from the code or not related; and, a test that was failing now passes.

Comment 7

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Setting P1 as this appears to be being worked on.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   8a4dbd5..57bb459  master -> master