Closed Bug 1368764 Opened 3 years ago Closed 3 years ago

Component watching relationship constant not exported in template constants

Categories

(bugzilla.mozilla.org :: Extensions, defect, P1)

Production
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: kthiessen, Assigned: dylan)

References

Details

Attachments

(1 file)

Excerpt from email from Comment # 35 on Bug 949655 from Byron Jones ‹:glob› at 2017-05-30 06:37:31 PDT:

<div id=3D"reason" style=3D"font-size: 90%; color: #666666">
    <hr style=3D"border: 1px dashed #969696">
    <b>You are receiving this mail because:</b>
    <ul>
          <li>You are watching the component for the bug.</li>
    </ul>
  </div>

Excerpt from email from Comment # 36 on Bug 949655 from neekbeta at 2017-05-30 07:52:04 PDT:

<div id=3D"reason" style=3D"font-size: 90%; color: #666666">
    <hr style=3D"border: 1px dashed #969696">
    <b>You are receiving this mail because:</b>
    <ul>
    </ul>
  </div>

Please note that in both emails the "X-Bugzilla-Watch-Reason: Component-Watcher" header is correctly present.

More details available on request, but I hope this is enough to start with.
This is because of bug 1352264. It's not enough to make 'constants' a variable, we must also set CONSTANT_NAMESPACE to something else -- else the template compiler gets confused and does constant folding.
Depends on: 1352264
To github.com:mozilla-bteam/bmo.git
   82ea853bd..316a5ce16  master -> master
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
It seems this fixed some cases of the bug, but not others.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Component: Email Notifications → Extensions: ComponentWatching
Summary: Bugmail no longer contains reason for receiving mail, defeating email filters → Component watching relationship constant not exported in template constants
Attached patch 1368764_1.patchSplinter Review
Because of constant folding, we moved the 'constants' to the VARIABLES hash (see in Bugzilla/Template.pm) but did not update the extensions using this.
Attachment #8872853 - Flags: review?(sebastinssanty)
Comment on attachment 8872853 [details] [diff] [review]
1368764_1.patch

I think sebastin is a bit busy, asking atoll so I can get this out next week.
Attachment #8872853 - Flags: review?(sebastinssanty) → review?(rsoderberg)
Comment on attachment 8872853 [details] [diff] [review]
1368764_1.patch

This is valid Perl, and the change is applied to three places correctly. r+, two assumptions: the string 'CONSTANTS' is either absent from the code or not related; and, a test that was failing now passes.
Attachment #8872853 - Flags: review?(rsoderberg) → review+
Setting P1 as this appears to be being worked on.
Priority: -- → P1
To git@github.com:mozilla-bteam/bmo.git
   8a4dbd5..57bb459  master -> master
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Component: Extensions: ComponentWatching → Extensions
You need to log in before you can comment on or make changes to this bug.