136885 - select box doesn't update display when text value of selected item changes

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Eric Kuzniar]

If you change the text value of a select box builds before about april 2002
would update the display as well, but current builds will show the proper value
in the drop down, if you changed the text value of the item that was currently
selected it does not change unless you select a different item, and then select
the previously selected item again. a simple testcase can be found at
http://www.linuxsquared.com/selectbug.html

Comment 1

[Eric Kuzniar]

Attachment: A simple test case

Comment 2

[Marc Boullet]

Confirming 2002041103 NT4
--->jkeiser

Comment 3

[Geraint]

Attachment: An alternative demonstration of changed text not displaying

Comment 4

[Geraint]

In Linux 2002041409 not only does the text not get updated but the drop down
appears detached from the select box - there is a visible gap on the screen
between the two

I am attaching a second text case which demonstrates text value change problem
without the drop down gap.

Modifying select boxes is a very commonplace JS practice and I would suggest
this should be fixed for Moz 1.0.0.
 

Comment 5

[Kevin McCluskey (gone)]

nsbeta1-

Comment 6

[John Keiser (jkeiser)]

*** Bug 138410 has been marked as a duplicate of this bug. ***

Comment 7

[John Keiser (jkeiser)]

*** Bug 140430 has been marked as a duplicate of this bug. ***

Comment 8

[John Keiser (jkeiser)]

*** Bug 143714 has been marked as a duplicate of this bug. ***

Comment 9

[John Keiser (jkeiser)]

Attachment: Patch

Comment 10

[rods (gone)]

Comment on attachment 83573 [details] [diff] [review]
Patch

r=rods

Comment 11

[Mike Shaver (:shaver emeritus)]

Comment on attachment 83573 [details] [diff] [review]
Patch

I HAVE NEVER SEEN A MORE PERFECT PATCH!

sr=shaver.

Comment 12

[John Keiser (jkeiser)]

This fix is so low-risk that it's ridiculous; it has decent visibility, too,
there are several dups.  Should be considered for nsbeta1.

Comment 13

[John Keiser (jkeiser)]

Attachment: Patch v1.1

This patch is a bit more optimized; since AppendChildTo() already handles
notification the only case we have to deal with is where we are changing the
existing text node.

Comment 14

[rods (gone)]

Comment on attachment 83924 [details] [diff] [review]
Patch v1.1

r=rods

Comment 15

[Marc Attinasi]

Comment on attachment 83924 [details] [diff] [review]
Patch v1.1

sr=attinasi

Comment 16

[John Keiser (jkeiser)]

fix checked in to trunk.

Comment 17

[Matias Larsson]

I'm sorry but this bug is still in Mozilla 1.0 Final. (At least on Mac OS X)

Comment 18

[Dean Fitzgerald]

Not fixed on my win2k box too (Gecko/20020530).