Open Bug 1368858 Opened 7 years ago Updated 2 years ago

Improve the Form Autofill heuristics to not depend on the order of DOM elements

Categories

(Toolkit :: Form Autofill, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: selee, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [form autofill])

(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #78)
> Comment on attachment 8861454 [details]
> Bug 1349490 - Part 2: Use a set of regexp to recognize the input autofill
> type.;
> 
> https://reviewboard.mozilla.org/r/133446/#review146296
> 
> > I ever considered that...
> > Using the way with existingFieldNames here is to give address-line[1-3] field names to these inputs early.
> > 
> > I think we can implement the post process after all getInfo in getFormInfo if needed.
> > However, the current process can satisfy the current requirement.
> 
> Isn't the proposed solution dependent on the DOM order of the form fields
> e.g. if `address-line1` appears after `address-line2` then it may be
> incorrect? I think that's an edge case but I still don't like the change to
> the API, requiring existing field names to be passed in. I guess we can fix
> it in a follow-up so that we can get this landed.
Whiteboard: [form autofill:M3] → [form autofill:MVP]
Remove it from MVP scope until we find a test case.
Whiteboard: [form autofill:MVP] → [form autofill]
Blocks: 1392528
Component: Form Manager → Form Autofill
Moving to p3 because no activity for at least 24 weeks.
Priority: P1 → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.