1368872 - Enable Form Autofill Heuristics by default

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P1)

Description

[Sean Lee [:seanlee][:weilonge]]

(In reply to Sean Lee [:seanlee][:weilonge] from comment #75)
> Hey MattN,
> 
> I add a new commit Part 4 for toggling heuristics.
> Here is the talos try link :
> 1. Pref off
> https://treeherder.mozilla.org/perf.html#/
> compare?originalProject=try&originalRevision=3115aeeca1837a89ba1e75efe29746c9
> 691b9376&newProject=try&newRevision=90d3059b805fe932d546cc4fb259ed267f83351f&
> framework=1
> 2. Pref on
> https://treeherder.mozilla.org/perf.html#/
> compare?originalProject=try&originalRevision=3115aeeca1837a89ba1e75efe29746c9
> 691b9376&newProject=try&newRevision=2e4f1e8bce809ceced67c45133abcb2be7a4f2aa&
> framework=1

We should fix these talos test fails (see 2. Pref on) to enable the heuristics by default:
tpaint opt e10s - windows7-32
tps opt e10s - linux64
                  - tps ifeng.com opt e10s
                  - tps mail.ru opt e10s

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1368872 - Enable FormAutofill Heuristics by default.;

Review commit: https://reviewboard.mozilla.org/r/145738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145738/

Comment 2

[Sean Lee [:seanlee][:weilonge]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4855892573c6043a453d76175b83460c8cbf1e6

Benchmark: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=a258e83ede8e6dd7398431c843b78495c9b1ff7e&newProject=try&newRevision=c4855892573c6043a453d76175b83460c8cbf1e6&framework=1&showOnlyImportant=0

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8874378 [details]
Bug 1368872 - Enable FormAutofill Heuristics by default.;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145738/diff/1-2/

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Since bug 1364818 refines `autofocus` case, the talos issue of this bug is resloved [1].
Then we can turn on heuristics by default now.

[1] https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=74da47a9d257c3e7f0467c0c68473d1f5ad3cd16&newProject=try&newRevision=6be621841492d5464c126b12c2bee4cb323e4acb&framework=1&showOnlyImportant=0

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 8874378 [details]
Bug 1368872 - Enable FormAutofill Heuristics by default.;

https://reviewboard.mozilla.org/r/145738/#review150638

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60afe5db0395
Enable FormAutofill Heuristics by default.; r=MattN

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/60afe5db0395

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af923cfd5121
Update Autofill work-in-progress warning to reflect heuristic and <select> support. r=me

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/af923cfd5121