1368910 - Update cubeb from upstream to 3428c2b

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Alex Chronopoulos [:achronop]]

Pick commit:

3428c2b Alex Chronopoulos       audiounit: remove stream lock from property listener and get position

Comment 1

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cda03201b522c7fd3e7b10827b04bf5483e32816
Bug 1368910 - Update cubeb from upstream to 3428c2b. r=kinetik

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cda03201b522

Comment 3

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1368910 - Uplift cubeb commit 3428c2b.

Approval Request Comment
[Feature/Bug causing the regression]: This cubeb commit which solves Bug 1335512
[User impact if declined]: Video playback stop working after a while when plug/unplug external headset
[Is this code covered by automated tests?]:No
[Has the fix been verified in Nightly?]: It is landed in m-c yesterday (2017-05-31)
[Needs manual test from QE? If yes, steps to reproduce]: It's hard to repro reported noticed the issue once per 2 week use and only when system was under load.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: It's not risky patch, small fix ~3 lines which make sure that a specific notification callback cannot be blocked by audio stream mutex. 
[Why is the change risky/not risky?]:not risky
[String changes made/needed]:N/A

Comment 4

[Jean-Yves Avenard [:jya]]

could we get confirmation that this does fix the bug reported in many places?

I haven't seen any confirmations that it does fix it from anyone who had the issues.

Comment 5

[Matthew Gregan [:kinetik]]

Comment on attachment 8873357 [details] [diff] [review]
Bug 1368910 - Uplift cubeb commit 3428c2b.

Review of attachment 8873357 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but would be good to get confirmation of the fix before uplifting.

Comment 6

[Alex Chronopoulos [:achronop]]

The issue is hard to repro and we running to get it to beta before the code freeze. The fix is certainly good and solves a deadlock case very similar the one described here. I am in communication with the reporter who told me that will reopen the initial issue (bug 1335512) in case he has it again. In any case we want that to beta.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8873357 [details] [diff] [review]
Bug 1368910 - Uplift cubeb commit 3428c2b.

While this maybe a good thing, I would prefer to let this ride the 55 train due to the following reasons: 1) this fix hasn't baked enough in nightly and we are unaware of fallouts. 2) If this turns out to be a big problem on release54 (don't think that's the case from release53, beta54), we can consider including this as a fix in a dot release, 3) need the bug opener to confirm this fixes the bug.

Comment 8

[Jean-Yves Avenard [:jya]]

Ritu, I think you should reconsider the severity of the problem.

It renders any video playback (including YouTube) inoperable. Requiring to exit Firefox and restart.

We've had dozen of bug reports on the matter, which likely indicates thousands of people affected.