Cleanup ProcessPriorityManager

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
This should be the last cleaning up patch for this component. It seems that now it's ready to be used on desktop.
Assignee

Comment 1

2 years ago
Posted patch cleanup.patchSplinter Review
Attachment #8872882 - Flags: review?(gsvelto)
Assignee

Updated

2 years ago
Blocks: 1366356
Comment on attachment 8872882 [details] [diff] [review]
cleanup.patch

Review of attachment 8872882 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM but your changes just made me realize that we still have wake lock support around. A grep of the code shows that it goes beyond gonk so maybe we can't strip it out yet but it's probably worth an investigation (navigator.requestWakeLock() should have been gone already though, I wonder why it's still there).
Attachment #8872882 - Flags: review?(gsvelto) → review+
Assignee

Comment 3

2 years ago
We must keep the wakelock because if a tab, not in focus, is playing audio, we don't want to reduce its priority.
Assignee

Comment 4

2 years ago
But yes, we should probably remove navigator.requestWakeLock()

Comment 5

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0ebe9dd56ae
Remove gonk specific code from ProcessPriorityManager, r=gsvelto

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b0ebe9dd56ae
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.