Closed Bug 1368941 Opened 3 years ago Closed 3 years ago

Cleanup ProcessPriorityManager

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

This should be the last cleaning up patch for this component. It seems that now it's ready to be used on desktop.
Attached patch cleanup.patchSplinter Review
Attachment #8872882 - Flags: review?(gsvelto)
Blocks: 1366356
Comment on attachment 8872882 [details] [diff] [review]
cleanup.patch

Review of attachment 8872882 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM but your changes just made me realize that we still have wake lock support around. A grep of the code shows that it goes beyond gonk so maybe we can't strip it out yet but it's probably worth an investigation (navigator.requestWakeLock() should have been gone already though, I wonder why it's still there).
Attachment #8872882 - Flags: review?(gsvelto) → review+
We must keep the wakelock because if a tab, not in focus, is playing audio, we don't want to reduce its priority.
But yes, we should probably remove navigator.requestWakeLock()
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0ebe9dd56ae
Remove gonk specific code from ProcessPriorityManager, r=gsvelto
https://hg.mozilla.org/mozilla-central/rev/b0ebe9dd56ae
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.