1368941 - Cleanup ProcessPriorityManager

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

This should be the last cleaning up patch for this component. It seems that now it's ready to be used on desktop.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: cleanup.patch

Comment 2

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8872882 [details] [diff] [review]
cleanup.patch

Review of attachment 8872882 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM but your changes just made me realize that we still have wake lock support around. A grep of the code shows that it goes beyond gonk so maybe we can't strip it out yet but it's probably worth an investigation (navigator.requestWakeLock() should have been gone already though, I wonder why it's still there).

Comment 3

[Andrea Marchesini [:baku]]

We must keep the wakelock because if a tab, not in focus, is playing audio, we don't want to reduce its priority.

Comment 4

[Andrea Marchesini [:baku]]

But yes, we should probably remove navigator.requestWakeLock()

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0ebe9dd56ae
Remove gonk specific code from ProcessPriorityManager, r=gsvelto

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b0ebe9dd56ae