1368952 - Remove locking from SourceBufferResource

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jean-Yves Avenard [:jya]]

MediaResource objects are supposed to be threadsafe and historically the SourceBufferResource had to be too.

However, with the new MediaSource architecture enable in Firefox 41, this is no longer an issue.

SourceBufferResource is only ever accessed on the same taskqueue (the MediaSource taskqueue)

We can simplify the code and remove all locking there.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1368952: P1. Fix coding style.

Review commit: https://reviewboard.mozilla.org/r/144472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144472/

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1368952: P2. Remove monitor from SourceBufferResource.

a SourceBufferResource is only ever used on the same taskqueue. It doesn't require to be thread-safe.

Review commit: https://reviewboard.mozilla.org/r/144474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144474/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8872924 [details]
Bug 1368952: P1. Fix coding style.

https://reviewboard.mozilla.org/r/144472/#review148248

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8872925 [details]
Bug 1368952: P2. Remove monitor from SourceBufferResource.

https://reviewboard.mozilla.org/r/144474/#review148250

::: commit-message-41cfc:3
(Diff revision 1)
> +Bug 1368952: P2. Remove monitor from SourceBufferResource. r?gerald
> +
> +a SourceBufferResource is only ever used on the same taskqueue. It doesn't require to be thread-safe.

Capital 'A'.

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8872925 [details]
Bug 1368952: P2. Remove monitor from SourceBufferResource.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144474/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd2758cb931e
P1. Fix coding style. r=gerald
https://hg.mozilla.org/integration/autoland/rev/7b2c68611d9d
P2. Remove monitor from SourceBufferResource. r=gerald

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd2758cb931e
https://hg.mozilla.org/mozilla-central/rev/7b2c68611d9d