Closed Bug 1368952 Opened 3 years ago Closed 3 years ago
Remove locking from Source
MediaResource objects are supposed to be threadsafe and historically the SourceBufferResource had to be too. However, with the new MediaSource architecture enable in Firefox 41, this is no longer an issue. SourceBufferResource is only ever accessed on the same taskqueue (the MediaSource taskqueue) We can simplify the code and remove all locking there.
Comment on attachment 8872924 [details] Bug 1368952: P1. Fix coding style. https://reviewboard.mozilla.org/r/144472/#review148248
Attachment #8872924 - Flags: review?(gsquelart) → review+
Comment on attachment 8872925 [details] Bug 1368952: P2. Remove monitor from SourceBufferResource. https://reviewboard.mozilla.org/r/144474/#review148250 ::: commit-message-41cfc:3 (Diff revision 1) > +Bug 1368952: P2. Remove monitor from SourceBufferResource. r?gerald > + > +a SourceBufferResource is only ever used on the same taskqueue. It doesn't require to be thread-safe. Capital 'A'.
Attachment #8872925 - Flags: review?(gsquelart) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/fd2758cb931e P1. Fix coding style. r=gerald https://hg.mozilla.org/integration/autoland/rev/7b2c68611d9d P2. Remove monitor from SourceBufferResource. r=gerald
You need to log in before you can comment on or make changes to this bug.