Remove locking from SourceBufferResource

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
MediaResource objects are supposed to be threadsafe and historically the SourceBufferResource had to be too.

However, with the new MediaSource architecture enable in Firefox 41, this is no longer an issue.

SourceBufferResource is only ever accessed on the same taskqueue (the MediaSource taskqueue)

We can simplify the code and remove all locking there.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8872924 [details]
Bug 1368952: P1. Fix coding style.

https://reviewboard.mozilla.org/r/144472/#review148248
Attachment #8872924 - Flags: review?(gsquelart) → review+
Comment on attachment 8872925 [details]
Bug 1368952: P2. Remove monitor from SourceBufferResource.

https://reviewboard.mozilla.org/r/144474/#review148250

::: commit-message-41cfc:3
(Diff revision 1)
> +Bug 1368952: P2. Remove monitor from SourceBufferResource. r?gerald
> +
> +a SourceBufferResource is only ever used on the same taskqueue. It doesn't require to be thread-safe.

Capital 'A'.
Attachment #8872925 - Flags: review?(gsquelart) → review+
Comment hidden (mozreview-request)

Comment 6

2 years ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fd2758cb931e
P1. Fix coding style. r=gerald
https://hg.mozilla.org/integration/autoland/rev/7b2c68611d9d
P2. Remove monitor from SourceBufferResource. r=gerald

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fd2758cb931e
https://hg.mozilla.org/mozilla-central/rev/7b2c68611d9d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.