Implement WebVR reftest for verifying onVRPresentChange

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 fixed, firefox56 fixed)

Details

Attachments

(1 attachment)

For the onVRPresentChange() testcase, we will ask to resize while vrDisplay is presenting and make webglCanvas.width and height to be the eye width and height of VRDisplay.

Please refer, https://github.com/toji/webvr.info/blob/e00559c5b8bd1bc7ad050e9be07991ccf8c986ad/samples/XX-vr-controllers.html#L228.
Blocks: 1229478
Assignee: nobody → dmu
Need to check why the submit frame image is skewed.
Comment on attachment 8875207 [details]
Bug 1368990 - Add reftest for verifying onVRPresentChange;

https://reviewboard.mozilla.org/r/146616/#review154722

Looks great, thanks!
Attachment #8875207 - Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf25fd50974c
Add reftest for verifying onVRPresentChange; r=kip
This is a reftest, and I recommend to uplift it to beta for preventing other regressions.
https://hg.mozilla.org/mozilla-central/rev/cf25fd50974c
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment on attachment 8875207 [details]
Bug 1368990 - Add reftest for verifying onVRPresentChange;

Approval Request Comment
[Feature/Bug causing the regression]: This is a new reftest for protecting from regression.
[User impact if declined]: Nope.
[Is this code covered by automated tests?]: yes.
[Has the fix been verified in Nightly?]: yes.
[Needs manual test from QE? If yes, steps to reproduce]: nope.
[List of other uplifts needed for the feature/fix]: nope.
[Is the change risky?]: nope.
[Why is the change risky/not risky?]: just a reftest.
[String changes made/needed]: nope.
Attachment #8875207 - Flags: approval-mozilla-beta?
Comment on attachment 8875207 [details]
Bug 1368990 - Add reftest for verifying onVRPresentChange;

I'm confused by the gfxVRPuppet.cpp change, which doesn't seem to be covered by "add reftest"?
Flags: needinfo?(dmu)
(In reply to Julien Cristau [:jcristau] from comment #10)
> Comment on attachment 8875207 [details]
> Bug 1368990 - Add reftest for verifying onVRPresentChange;
> 
> I'm confused by the gfxVRPuppet.cpp change, which doesn't seem to be covered
> by "add reftest"?

The code from gfxVRPuppet.cpp is only run by reftest or mochitest. It is behind pref::"dom.vr.test". We didn't enable it from our build.
Flags: needinfo?(dmu)
Comment on attachment 8875207 [details]
Bug 1368990 - Add reftest for verifying onVRPresentChange;

Thanks :daoshengmu.  Add reftest for VR issue, beta55+
Attachment #8875207 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.