Closed
Bug 1368990
Opened 4 years ago
Closed 4 years ago
Implement WebVR reftest for verifying onVRPresentChange
Categories
(Core :: WebVR, enhancement)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: daoshengmu, Assigned: daoshengmu)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
kip
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
For the onVRPresentChange() testcase, we will ask to resize while vrDisplay is presenting and make webglCanvas.width and height to be the eye width and height of VRDisplay. Please refer, https://github.com/toji/webvr.info/blob/e00559c5b8bd1bc7ad050e9be07991ccf8c986ad/samples/XX-vr-controllers.html#L228.
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → dmu
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•4 years ago
|
||
Need to check why the submit frame image is skewed.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•4 years ago
|
||
Try looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=f19c3976aab7f0d49f19204294395ab5cd7b5513
Comment 5•4 years ago
|
||
mozreview-review |
Comment on attachment 8875207 [details] Bug 1368990 - Add reftest for verifying onVRPresentChange; https://reviewboard.mozilla.org/r/146616/#review154722 Looks great, thanks!
Attachment #8875207 -
Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf25fd50974c Add reftest for verifying onVRPresentChange; r=kip
Assignee | ||
Comment 7•4 years ago
|
||
This is a reftest, and I recommend to uplift it to beta for preventing other regressions.
![]() |
||
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cf25fd50974c
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 9•4 years ago
|
||
Comment on attachment 8875207 [details] Bug 1368990 - Add reftest for verifying onVRPresentChange; Approval Request Comment [Feature/Bug causing the regression]: This is a new reftest for protecting from regression. [User impact if declined]: Nope. [Is this code covered by automated tests?]: yes. [Has the fix been verified in Nightly?]: yes. [Needs manual test from QE? If yes, steps to reproduce]: nope. [List of other uplifts needed for the feature/fix]: nope. [Is the change risky?]: nope. [Why is the change risky/not risky?]: just a reftest. [String changes made/needed]: nope.
Attachment #8875207 -
Flags: approval-mozilla-beta?
Comment 10•4 years ago
|
||
Comment on attachment 8875207 [details] Bug 1368990 - Add reftest for verifying onVRPresentChange; I'm confused by the gfxVRPuppet.cpp change, which doesn't seem to be covered by "add reftest"?
Flags: needinfo?(dmu)
Assignee | ||
Comment 11•4 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #10) > Comment on attachment 8875207 [details] > Bug 1368990 - Add reftest for verifying onVRPresentChange; > > I'm confused by the gfxVRPuppet.cpp change, which doesn't seem to be covered > by "add reftest"? The code from gfxVRPuppet.cpp is only run by reftest or mochitest. It is behind pref::"dom.vr.test". We didn't enable it from our build.
Flags: needinfo?(dmu)
Comment 12•4 years ago
|
||
Comment on attachment 8875207 [details] Bug 1368990 - Add reftest for verifying onVRPresentChange; Thanks :daoshengmu. Add reftest for VR issue, beta55+
Attachment #8875207 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•4 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/911dc640c42c
status-firefox55:
--- → fixed
Flags: in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•