remove or fix WARNING: '!mMainThread', file xpcom/threads/nsThreadManager.cpp, line 330

RESOLVED FIXED in Firefox 56

Status

()

Core
XPCOM
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: mayhemer, Assigned: erahm)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Comment hidden (empty)
This is the #2 most verbose warning during testing:

> 131280 WARNING: '!mMainThread', file xpcom/threads/nsThreadManager.cpp, line 330

This warning [1] shows up in the following test suites:

>   4932 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
>   4860 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
>   4503 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
>   4473 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
>   4361 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
>   4277 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
>   4266 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
>   3898 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
>   3874 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
>   3743 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
>   3732 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
>   3446 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
>   2709 - test-linux64/debug-web-platform-tests-reftests-e10s Wr
>   2594 - test-linux64/debug-web-platform-tests-1 wpt1
>   2578 - test-linux64/debug-mochitest-clipboard-e10s cl
>   2508 - test-linux64/debug-web-platform-tests-10 wpt10
>   2375 - test-linux64/debug-web-platform-tests-12 wpt12
>   2349 - test-linux64/debug-web-platform-tests-9 wpt9
>   2275 - test-linux64/debug-web-platform-tests-6 wpt6
>   2254 - test-linux64/debug-web-platform-tests-11 wpt11
>   2206 - test-linux64/debug-web-platform-tests-4 wpt4
>   2067 - test-linux64/debug-web-platform-tests-2 wpt2
>   1986 - test-linux64/debug-web-platform-tests-3 wpt3
>   1984 - test-linux64/debug-web-platform-tests-5 wpt5
>   1980 - test-linux64/debug-web-platform-tests-8 wpt8
>   1977 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
>   1783 - test-linux64/debug-web-platform-tests-reftests Wr
>   1741 - test-linux64/debug-web-platform-tests-7 wpt7
>   1417 - test-linux64/debug-mochitest-2 2
>   1347 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
>   1291 - test-linux64/debug-mochitest-chrome-1 c1
>   1280 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
>   1261 - test-linux64/debug-mochitest-chrome-3 c3
>   1233 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
>   1223 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
>   1137 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
>   1125 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
>   1113 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
>   1088 - test-linux64/debug-mochitest-e10s-10 10
>   1071 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
>   1066 - test-linux64/debug-mochitest-clipboard cl
>   1040 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
>    945 - test-linux64/debug-mochitest-chrome-2 c2
>    903 - test-linux64/debug-mochitest-e10s-5 5
>    872 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
>    844 - test-linux64/debug-mochitest-e10s-6 6
>    825 - test-linux64/debug-mochitest-e10s-4 4
>    815 - test-linux64/debug-mochitest-e10s-3 3
>    797 - test-linux64/debug-mochitest-e10s-7 7
>    794 - test-linux64/debug-mochitest-e10s-1 1
>    792 - test-linux64/debug-mochitest-e10s-2 2
>    782 - test-linux64/debug-mochitest-e10s-8 8
>    773 - test-linux64/debug-mochitest-e10s-9 9
>    747 - test-linux64/debug-mochitest-4 4
>    677 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
>    612 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
>    611 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
>    514 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
>    502 - test-linux64/debug-mochitest-10 10
>    492 - test-linux64/debug-mochitest-3 3
>    490 - test-linux64/debug-mochitest-5 5
>    466 - test-linux64/debug-mochitest-6 6
>    465 - test-linux64/debug-mochitest-8 8
>    461 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
>    459 - test-linux64/debug-mochitest-gpu-e10s gpu
>    421 - test-linux64/debug-mochitest-9 9
>    411 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
>    408 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
>    405 - test-linux64/debug-mochitest-7 7
>    402 - test-linux64/debug-mochitest-1 1
>    379 - test-linux64/debug-mochitest-browser-chrome-1 bc1
>    371 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
>    367 - test-linux64/debug-mochitest-browser-chrome-11 bc11
>    365 - test-linux64/debug-mochitest-browser-chrome-8 bc8
>    346 - test-linux64/debug-mochitest-media-e10s-3 mda3
>    340 - test-linux64/debug-mochitest-browser-chrome-6 bc6
>    340 - test-linux64/debug-mochitest-browser-chrome-7 bc7
>    339 - test-linux64/debug-mochitest-browser-chrome-5 bc5
>    337 - test-linux64/debug-mochitest-browser-chrome-9 bc9
>    324 - test-linux64/debug-reftest-no-accel-1 Ru1
>    312 - test-linux64/debug-mochitest-webgl-e10s-3 gl3
>    309 - test-linux64/debug-mochitest-browser-chrome-10 bc10
>    281 - test-linux64/debug-mochitest-browser-chrome-3 bc3
>    275 - test-linux64/debug-mochitest-devtools-chrome-5 dt5
>    257 - test-linux64/debug-reftest-e10s-1 R1
>    236 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
>    234 - test-linux64/debug-reftest-1 R1
>    233 - test-linux64/debug-reftest-e10s-4 R4
>    231 - test-linux64/debug-mochitest-webgl-3 gl3
>    206 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
>    191 - test-linux64/debug-mochitest-browser-chrome-2 bc2
>    184 - test-linux64/debug-mochitest-media-e10s-2 mda2
>    171 - test-linux64/debug-mochitest-devtools-chrome-4 dt4
>    169 - test-linux64/debug-mochitest-browser-chrome-4 bc4
>    168 - test-linux64/debug-mochitest-media-3 mda3
>    144 - test-linux64/debug-mochitest-devtools-chrome-7 dt7
>    144 - test-linux64/debug-mochitest-devtools-chrome-2 dt2
>    143 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
>    130 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
>    125 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
>    125 - test-linux64/debug-mochitest-webgl-e10s-1 gl1
>    122 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
>    115 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
>    115 - test-linux64/debug-mochitest-devtools-chrome-6 dt6
>    115 - test-linux64/debug-mochitest-devtools-chrome-1 dt1
>    110 - test-linux64/debug-mochitest-media-e10s-1 mda1
>    104 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
>    103 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
>    103 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
>    101 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
>     90 - test-linux64/debug-reftest-e10s-7 R7
>     86 - test-linux64/debug-reftest-e10s-8 R8
>     86 - test-linux64/debug-reftest-e10s-3 R3
>     86 - test-linux64/debug-mochitest-devtools-chrome-9 dt9
>     85 - test-linux64/debug-reftest-e10s-5 R5
>     85 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
>     85 - test-linux64/debug-mochitest-media-2 mda2
>     85 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
>     85 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
>     82 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
>     77 - test-linux64/debug-reftest-e10s-2 R2
>     77 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
>     77 - test-linux64/debug-reftest-e10s-6 R6
>     77 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
>     77 - test-linux64/debug-crashtest-e10s C
>     67 - test-linux64/debug-mochitest-webgl-1 gl1
>     66 - test-linux64/debug-mochitest-webgl-e10s-2 gl2
>     58 - test-linux64/debug-mochitest-devtools-chrome-8 dt8
>     57 - test-linux64/debug-mochitest-jetpack JP
>     57 - test-linux64/debug-mochitest-devtools-chrome-3 dt3
>     56 - test-linux64/debug-mochitest-media-1 mda1
>     54 - test-linux64/debug-reftest-no-accel-7 Ru7
>     52 - test-linux64/debug-reftest-no-accel-4 Ru4
>     51 - test-linux64/debug-mochitest-a11y a11y
>     44 - test-linux64/debug-firefox-ui-functional-local en-US
>     33 - test-linux64/debug-reftest-7 R7
>     30 - test-linux64/debug-reftest-no-accel-8 Ru8
>     30 - test-linux64/debug-mochitest-webgl-2 gl2
>     29 - test-linux64/debug-mochitest-browser-chrome-14 bc14
>     29 - test-linux64/debug-crashtest C
>     29 - test-linux64/debug-mochitest-browser-chrome-16 bc16
>     29 - test-linux64/debug-mochitest-devtools-chrome-10 dt10
>     28 - test-linux64/debug-reftest-2 R2
>     28 - test-linux64/debug-reftest-no-accel-6 Ru6
>     28 - test-linux64/debug-reftest-no-accel-3 Ru3
>     28 - test-linux64/debug-reftest-no-accel-5 Ru5
>     28 - test-linux64/debug-reftest-5 R5
>     28 - test-linux64/debug-reftest-no-accel-2 Ru2
>     28 - test-linux64/debug-mochitest-browser-chrome-13 bc13
>     28 - test-linux64/debug-mochitest-browser-chrome-15 bc15
>     28 - test-linux64/debug-reftest-3 R3
>     28 - test-linux64/debug-reftest-4 R4
>     28 - test-linux64/debug-reftest-6 R6
>     28 - test-linux64/debug-mochitest-browser-chrome-12 bc12
>     28 - test-linux64/debug-reftest-8 R8
>     26 - test-linux64/debug-firefox-ui-functional-remote en-US
>      7 - test-linux64/debug-gtest GTest

It shows up in 1956 tests. A few of the most prevalent:

>  28703 - [e10s] Shutdown
>  13176 -        Shutdown
>    558 -        file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-50.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/support/color-green-ref.html
>    343 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/variable-declaration-45.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/variables/support/color-green-ref.html
>    304 - [e10s] file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/counters/t1204-implied-02-d-test.html == file:///home/worker/workspace/build/tests/reftest/tests/layout/reftests/counters/t1204-implied-02-d-reference.html
>    287 - [e10s] dom/tests/browser/browser_largeAllocation_non_win32.js
>    193 - [e10s] /html/semantics/text-level-semantics/the-wbr-element/wbr-element.html
>    176 -        dom/base/test/chrome/test_swapFrameLoaders.xul
>    166 -        /html/semantics/text-level-semantics/the-wbr-element/wbr-element.html
>    153 -        /html/semantics/grouping-content/the-pre-element/pre-newline-bidi.html

[1] https://hg.mozilla.org/mozilla-central/annotate/72346a4d6afc/xpcom/threads/nsThreadManager.cpp#l330
Blocks: 765224
See also bug 1374414, this warning always precedes those warnings so that chain is responsible for ~81,000 instances. Nathan, it seems like there's very little value to this warning, wdyt about just removing it?
Flags: needinfo?(nfroyd)
(In reply to Eric Rahm [:erahm] (please no mozreview requests) from comment #2)
> See also bug 1374414, this warning always precedes those warnings so that
> chain is responsible for ~81,000 instances. Nathan, it seems like there's
> very little value to this warning, wdyt about just removing it?

Sure, let's do that.
Flags: needinfo?(nfroyd)
Created attachment 8879620 [details] [diff] [review]
Stop warning if the mainThread is null in GetCurrentThread
Attachment #8879620 - Flags: review?(nfroyd)
Assignee: nobody → erahm
Status: NEW → ASSIGNED
Attachment #8879620 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/95c0feba19eca15b4d7084e5eb0d5f08b4858b88
Bug 1369002 - Stop warning if the mainThread is null in GetCurrentThread. r=froydnj

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/95c0feba19ec
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56

Comment 7

4 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/e946980577ab
Backed out changeset 95c0feba19ec
had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=5845151f1a2cd00957fdd48e204542ccbdfaba1e because of the backout of bug 1351148 and in order to do a clean backout
Status: RESOLVED → REOPENED
status-firefox56: fixed → ---
Flags: needinfo?(erahm)
Resolution: FIXED → ---
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d0c0e1c39e6151bda40d30720a9aeb229a1118
Bug 1369002 - Stop warning if the mainThread is null in GetCurrentThread. r=froydnj
Flags: needinfo?(erahm)
https://hg.mozilla.org/mozilla-central/rev/26d0c0e1c39e
Status: REOPENED → RESOLVED
Last Resolved: 4 months ago4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.