1369006 - [LeanPlum] - Default Browser is still triggered even if Firefox is set as the default browser

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Bogdan Surd, QA [:bsurd, NI]]

Device:
 - Nexus 5 (Android 6.0.1);
 - Nexus 7 (Android 7.0);

Steps to reproduce:
1. Open Fennec, load any page and save it as a bookmark.
2. Close Fennec, go into Android settings and set Nightly as your default browser.
3. Open Fennec, go to the Bookmarks tab and tap on your previously saved bookmark.

Expected result:
 The Default Browser should not be triggered any more.

Actual result:
 The Default Browser trigger is still being displayed.

Video: https://goo.gl/Q78R0B

Comment 1

[Sorina Florean [:sflorean]]

This behavior is also reproducible when Fennec is set as default browser from Gmail app (open a link->Fennec->always). And then the app is launched.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Hi Sorina
May I know which App Name you used to set as default browser?
If the app is from Google Play Store, we should use org.mozilla.fennec_aurora.
Thanks!

Comment 3

[Sorina Florean [:sflorean]]

(In reply to Nevin Chen [:nechen] from comment #2)
> Hi Sorina
> May I know which App Name you used to set as default browser?
> If the app is from Google Play Store, we should use
> org.mozilla.fennec_aurora.
> Thanks!

This was the name of app, but I will investigate more. Was reproducible on Huawei Honor (Android 5.1.1).

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Turns out that only some phones have this problem.
It worked on my Nexus 5 (5.1.1) and Max's Pixel XL (7.1.2).
But it didn't work on my Pixel L (7.1.2).
My suggestion is to make the promot more generic ( e.g. Set Firefox as default browser?  No/Already v.s. Yes)

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Hi Sebastian, Max

Could you think of any setting I may touched to cause this issue? 
My default browser in Settings is ignore by the system.
The resolved activity on non-working devices is pointing to com.google.android.setupwizard.util.WebDialogActivity.
All I can found is this[1]. Looks like an Android/Google behavior.



[1] https://android.googlesource.com/platform/packages/apps/Stk/+/0bdc71924b41bc51e3d71118a1ae77f532f60ef9

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Oh interesting. I haven't seen this before. What happens if this activity is launched on the device?

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

setting it as P2 as it should not block the SDK to land. If we can't reliably detect default browser, we can drop this use case initially.

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Turns out Chromium is using the same code to check for default browser.[1]

[1] https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/DefaultBrowserInfo.java?rcl=02c38a03eeb541347abab892f220e82921cb6796&l=132


This should be an edge case( for those phones not completed their initial setup / setupwizard ). 

Hi Bogdan
Could you please help verify it again use a daily-use Android device?

Thanks a lot!

Comment 9

[Nevin Chen(Not active on Bugzilla)]

Attachment: Screenshot_20170602-191920.png

It's like this :)

Comment 10

[Bogdan Surd, QA [:bsurd, NI]]

(In reply to Nevin Chen [:nechen] from comment #8)
> Turns out Chromium is using the same code to check for default browser.[1]
> Hi Bogdan
> Could you please help verify it again use a daily-use Android device?

Hello Nevin,

 I've tested the issue again using different scenarios on the devices listed below and it was constantly reproducible on all of them.

Devices:
 - Nexus 5 (Android 6.0.1);
 - Nexus 6 (Android 7.0);
 - LG G4 (Android 5.1);
 - Oneplus Two (Android 6.0.1);
 - Samsung Galaxy Note 4 (Android 5.0.1);
 - Samsung Galaxy S4 (Android 4.4.2) - Personal device.

(In reply to Nevin Chen [:nechen] from comment #4)
> My suggestion is to make the promot more generic ( e.g. Set Firefox as
> default browser?  No/Already v.s. Yes)

 If we were to do it like this and we do not have any way of doing a check to see if the browser is set as default when tapping on a bookmark my suggestion would be to limit this trigger to appearing only once or twice as to avoid spamming the users.

Comment 11

[Nevin Chen(Not active on Bugzilla)]

Hi Bogdan
Sorry it's misunderstanding from my end. 
The bug you reported here is for message "M3_LoadBookmark Promote Default Browser".
But in fact, there shouldn't be a use case for "LoadBookmark" to prompt "DefaultBrowser"!
I just use a random deeplink to test the trigger "LoadBookmark"

My previous reply is base on "M1_Launch Promote Default Browser" use case.

Sorry for the confusion and thanks for the finding. I just paused this message on server side. So it shouldn't happen again.

Comment 12

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Yes. We don't really need the use case, so Nevin is removing the configuration from server-side.
Comment 8 is still valid but very corner case.
I'm resolving WORKSFORME this bug.

Comment 13

[Bogdan Surd, QA [:bsurd, NI]]

Confirmed this and clearing my needinfo. The trigger is no longer launched when loading a bookmark.