1369044 - Wrong assertion in AltDataOutputStreamParent::RecvWriteData

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Michal Novotny [:michal]]

We cannot guarantee that all data will be always successfully written here:
http://searchfox.org/mozilla-central/rev/b318c7dca7392bd16c0b11929f55b1be133f0b31/netwerk/protocol/http/AltDataOutputStreamParent.cpp#42

Comment 1

[Valentin Gosu [:valentin] (he/him)]

(In reply to Michal Novotny (:michal) from comment #0)
> We cannot guarantee that all data will be always successfully written here:
> http://searchfox.org/mozilla-central/rev/
> b318c7dca7392bd16c0b11929f55b1be133f0b31/netwerk/protocol/http/
> AltDataOutputStreamParent.cpp#42

What should we do instead? Retry, or fail?

Comment 2

[Michal Novotny [:michal]]

We already handle failure below the assertion. IMO rv can by a success code only when we write all data. So we can either remove this assertion, or change it to MOZ_ASSERT(n == data.Length() || NS_FAILED(rv));

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1369044 - Change assertion to handle call failure

Review commit: https://reviewboard.mozilla.org/r/150492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150492/

Comment 4

[Michal Novotny [:michal]]

Comment on attachment 8879159 [details]
Bug 1369044 - Change assertion to handle call failure

https://reviewboard.mozilla.org/r/150492/#review155160

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/922fc047c24d
Change assertion to handle call failure r=michal

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/922fc047c24d