Closed Bug 1369044 Opened 6 years ago Closed 6 years ago

Wrong assertion in AltDataOutputStreamParent::RecvWriteData

Categories

(Core :: Networking: Cache, enhancement)

Product:
Core
Component:
Networking: Cache
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: michal, Assigned: valentin)

References

Details

(Whiteboard: [necko-active])

Attachments

(1 file)

Bug 1369044 - Change assertion to handle call failure
59 bytes, text/x-review-board-request
michal
: review+
Details
Whiteboard: [necko-active]
(In reply to Michal Novotny (:michal) from comment #0)
> We cannot guarantee that all data will be always successfully written here:
> http://searchfox.org/mozilla-central/rev/
> b318c7dca7392bd16c0b11929f55b1be133f0b31/netwerk/protocol/http/
> AltDataOutputStreamParent.cpp#42

What should we do instead? Retry, or fail?
Flags: needinfo?(michal.novotny)
We already handle failure below the assertion. IMO rv can by a success code only when we write all data. So we can either remove this assertion, or change it to MOZ_ASSERT(n == data.Length() || NS_FAILED(rv));
Flags: needinfo?(michal.novotny)
Comment on attachment 8879159 [details]
Bug 1369044 - Change assertion to handle call failure

https://reviewboard.mozilla.org/r/150492/#review155160
Attachment #8879159 - Flags: review?(michal.novotny) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/922fc047c24d
Change assertion to handle call failure r=michal
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/922fc047c24d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.