1369061 - Add Solaris atomic.h to system-headers

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Petr Sumbera]

User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20170509094433

Steps to reproduce:

While linking libxul on Solaris I got:

 5:29.92 Undefined                   first referenced
 5:29.92  symbol                         in file
 5:29.92 membar_consumer                     ../../gfx/layers/Unified_cpp_gfx_layers8.o  (symbol scope specifies local binding)
 5:29.92 membar_producer                     ../components/protobuf/Unified_cpp_components_protobuf1.o  (symbol scope specifies local binding)
 5:29.92 atomic_cas_64                       ../components/protobuf/Unified_cpp_components_protobuf1.o  (symbol scope specifies local binding)

The reason is that config/gcc_hidden.h is included and atomic.h which is used in toolkit/components/protobuf/src/google/protobuf/stubs/atomicops_internals_solaris.h doesn't have its counterpart in system_wrappers/ to change GCC visibility to default.

Comment 1

[Petr Sumbera]

Attachment: Bug1369061.patch

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8873021 [details] [diff] [review]
Bug1369061.patch

Review of attachment 8873021 [details] [diff] [review]:
-----------------------------------------------------------------

Hopefully this shouldn't impact local atomic.h includes from media/ffvpx/libavutil in a meaningful way.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/da6426dca379
Add Solaris atomic.h to system-headers. r=glandium

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/da6426dca379