Closed
Bug 1369166
Opened 8 years ago
Closed 8 years ago
retrieving_symbol gauge no longer makes sense
Categories
(Socorro :: Symbols, task)
Socorro
Symbols
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Assigned: peterbe)
Details
When doing symbolication, we do a GETMANY on the LRU cache. Then we try to figure out how many bytes of data we got out. [0]
It does this by doing a `pickle.dumps()` on the object retrieved from `store.get_many()`. That almost made sense when our LRU django-redis configuration was using plain Python pickles.
In https://bugzilla.mozilla.org/show_bug.cgi?id=1364195 (https://github.com/mozilla-services/tecken/commit/c754e4064efb90f214b50d024ca5eca2a274af64) we switched to use msgpack as the serializer and zlib as the compressor.
Not only is this quite an expensive computation, it is also very little value in knowing how many bytes of data we, over time, retrieve out of the LRU cache.
Let's drop this measurement.
[0] https://github.com/mozilla-services/tecken/blob/76cd8f51194a5e6181cce2676d1b18e62443564b/tecken/symbolicate/views.py#L331
| Assignee | ||
Comment 1•8 years ago
|
||
Comment 2•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla-services/tecken
https://github.com/mozilla-services/tecken/commit/4c4c520d992bac15b4d22693f24b22c4acb6cb20
fixes bug 1369166 - retrieving_symbol gauge no longer makes sense (#135)
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•