1369245 - Convert browser/extensions/presentation/skin/shared/link.svg to use context paint

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement)

Description

[Jonathan Watt [:jwatt]]

We should convert browser/extensions/presentation/skin/shared/link.svg to use context paint for icon coloring instead of using filters.

Comment 1

[Jonathan Watt [:jwatt]]

I guess this should live under Device Permissions, since that's where bug 1289974 (the bug that added this SVG file) lives.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 3

[Jonathan Watt [:jwatt]]

Note that we have to use setProperty since '-moz-context-properties' is not enumerable, so can't be set via style.mozContextProperties.

Also note that I split up the non-intersecting regions of the path data into separate 'path' elements since that is likely to perform better.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8873253 [details] [diff] [review]
patch

Review of attachment 8873253 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: browser/extensions/presentation/skin/shared/link.svg
@@ +1,3 @@
> +<svg version="1.1" xmlns="http://www.w3.org/2000/svg"
> +     width="32px" height="32px" viewBox="0 0 32 32">
> +  <path fill="context-fill gray" d="M15.246,17.992c0,1.064,0.862,1.926,1.926,1.926c1.064,0,1.926-0.862,1.926-1.926c0-1.064-0.862-1.926-1.926-1.926C16.108,16.066,15.246,16.929,15.246,17.992z"/>

Note that I haven't actually checked to ensure that the icon looks the same.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ede3a183ade
Convert browser/extensions/presentation/skin/shared/link.svg to use context paint. r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ede3a183ade