1369257 - add "scrollbars" to window features for identity.launchWebAuthFlow

Status: VERIFIED FIXED

(WebExtensions :: Frontend, enhancement, P5)

Description

[Vlad Filippov (:vladikoff)]

Attachment: 592f720807a8e.jpg

See attached screenshot. The window opened with `browser.identity.launchWebAuthFlow` does not have a scrollbar. 

We use something like this to open the popup:

```
      return browser.identity.launchWebAuthFlow({
        interactive: true,
        url: `${AUTH_URL}&keys_jwk=${keyObject.base64JwkPublicKey}`
      });
```

Any ideas?

Comment 1

[Shane Caraveo (:mixedpuppy)]

I'm pretty sure that the window should be sizing to the content based on the html or body tags, however we could probably add "scrollbars" to the window features here:

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ext-c-identity.js#69

Comment 2

[Vasilica Tamas, QA [:vtamas]]

Attachment: Animation1.gif

Encountered this issue while using Zotero webextension running the following steps:
1.Launch Firefox with a clean profile.
2.Install the following extensions: https://www.zotero.org/download/
3.Navigate to a new webpage (e.g. https://www.ebay.com/)
4.Left click on webextension icon from toolbar menu and click on “Got it” button.
5.Right click on webextension icon from toolbar menu and select one of the “Save to Zotero” options.
5.A “Zotero” is Offline pop-up is displayed and click on “Enable Saving to Online Library” button.
6.Select “Register” or any item from the menu.

- There is no scrollbar displayed in webextension window and the page content could not be viewed using the mouse/touchpad.
- The window in not autoresizing according to content.
- This issue is not reproducible using the keyboard arrows.
- See attached screencast.
- Tested on Firefox 57.0a1 (2017-08-13), Firefox 56.0b2 (20170810180547) and Firefox 55.0.1 (20170809080026) under Windows 10 64-bit and Mac OS X 10.12.3.

Comment 3

[Vlad Filippov (:vladikoff)]

Ref: https://github.com/mozilla/notes/issues/231

Comment 4

[Vlad Filippov (:vladikoff)]

Attachment: Bug 1369257 - add "scrollbars" to window features for identity.launchWebAuthFlow

Review commit: https://reviewboard.mozilla.org/r/203336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203336/

Comment 5

[Vlad Filippov (:vladikoff)]

Attachment: bz1369257-fixed.gif

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8932301 [details]
Bug 1369257 - add "scrollbars" to window features for identity.launchWebAuthFlow

https://reviewboard.mozilla.org/r/203336/#review209118

Comment 7

[Shane Caraveo (:mixedpuppy)]

Thanks Vlad!  I think this is a simple enough change with enough value that we should request uplift after it lands.  Probably also need and easy STR written for QA.

Comment 8

[Vlad Filippov (:vladikoff)]

QA Instructions:

### STR

* Fresh Firefox Profile, download Notes extension: https://github.com/mozilla/notes/files/1506788/addon-2.0.0b2.zip, unzip the addon.
* Go to `about:debugging` load the addon via "Load Temporary Add-on"
* Click on the Sync Icon (two arrows on the bottom)
* Popup will open. You should be able to get scrollbars in the popup.
* See Before / After Gif https://bug1369257.bmoattachments.org/attachment.cgi?id=8932302

Also see: https://github.com/mozilla/notes/issues/231


Thanks for the review Shane!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac4865fb95b6
add "scrollbars" to window features for identity.launchWebAuthFlow r=mixedpuppy

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ac4865fb95b6

Comment 11

[Madalin Cotetiu]

Attachment: noScrollbars.png

Verified in Windows7(64bit) Ubuntu 16.04 (32bit) and MacOS 10.13.1 FF59 (Build ID 20171204100103)

Using the steps from comment 8 this is no longer reproducing. The scroll bars from the fxa pop up windows are displayed and are working correctly. But using the steps from comment 2 the issue is still reproducing:

Encountered this issue while using Zotero webextension running the following steps:
1.Launch Firefox with a clean profile.
2.Install the following extensions: https://www.zotero.org/download/
3.Navigate to a new webpage (e.g. https://www.ebay.com/)
4.Left click on webextension icon from toolbar menu and click on “Got it” button.
5.Right click on webextension icon from toolbar menu and select one of the “Save to Zotero” options.
5.A “Zotero” is Offline pop-up is displayed and click on “Enable Saving to Online Library” button.
6.Select “Register” or any item from the menu.


Should we open a new bug to track the issue from comment 2 and mark this one as verified or should we reopen it?

Comment 12

[Vlad Filippov (:vladikoff)]

That extension is not using the `identity.launchWebAuthFlow` API. They have their own implementation, so they either need to fix it or start using this API. Not much we can do but to just let them know that there are no scrollbars in their implementation.

Ref: http://v14d.com/i/5a25862080300.jpg

Comment 13

[Madalin Cotetiu]

Thanks for the response. Marking the bug as verified fixed.