Exit QuickLaunch mode on last window closing if multiple profiles

VERIFIED FIXED in mozilla1.0

Status

Core Graveyard
QuickLaunch (AKA turbo mode)
P1
major
VERIFIED FIXED
16 years ago
5 years ago

People

(Reporter: Bill Law, Assigned: Bill Law)

Tracking

({qawanted})

Trunk
mozilla1.0
x86
Windows 2000
qawanted

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ADT1])

Attachments

(1 attachment)

fix
2.22 KB, patch
Stephen P. Morse
: review+
Blake Ross
: superreview+
jesup
: approval+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
We decided to implement new code that will run when in Quick Launch mode.  This
code will check, at last window closing, whether the user has multiple profiles
defined and if so, automatically exit QuickLaunch mode (and since the last
window is closing, exit Mozilla).

This code will be enabled via a pref that will default to "off."  The plan is to
change this default to "on" (or remove the pref check) if we are unable to get
QuickLaunch working reliably in multi-profile cases.
(Assignee)

Comment 1

16 years ago
Nominating
Keywords: nsbeta1
Priority: -- → P1
Target Milestone: --- → mozilla1.0
(Assignee)

Updated

16 years ago
Blocks: 108795

Comment 2

16 years ago
nsbeta1+/ADT1
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [ADT1]
(Assignee)

Comment 3

16 years ago
Created attachment 78870 [details] [diff] [review]
fix
(Assignee)

Comment 4

16 years ago
Fix is already attached, just needs reviews/approval.
Whiteboard: [ADT1] → [ADT1] ETA 4/16

Comment 5

16 years ago
Comment on attachment 78870 [details] [diff] [review]
fix

r=morse
Attachment #78870 - Flags: review+

Comment 6

16 years ago
Comment on attachment 78870 [details] [diff] [review]
fix

Looks good. sr=blake
Attachment #78870 - Flags: superreview+

Comment 7

16 years ago
Adding adt1.0.0. Pls land this on the trunk tonight, and have grace verify that
it is resolved and causes no regressions.
Keywords: adt1.0.0
(Assignee)

Comment 8

16 years ago
Landed on trunk.
Comment on attachment 78870 [details] [diff] [review]
fix

a=rjesup@wgate.com
Attachment #78870 - Flags: approval+

Comment 10

16 years ago
grace - is this fixed on the trunk? where ther any regressions introduced?
Whiteboard: [ADT1] ETA 4/16 → [ADT1] [ETA 4/16]

Comment 11

16 years ago
I am waiting for a trunk build for 4/17- this says checked in on 4/16 at 8pm- no 
build since then
shouldn't we be defaulting "browser.turbo.singleProfileOnly" to true in all.js?
(Assignee)

Comment 13

16 years ago
Seth: the plan is to do that if and when we have to give up on fixing the
various multi-profile bugs.  I don't think we're at that point yet.

Comment 14

16 years ago
We have give it our best shot, but if we do flip that switch, we need to do so
in time to get adequate testing.

Comment 15

16 years ago
Agreed, we don't believe we are the point to give up on Multiple Profile QL
right now. 

Comment 16

16 years ago
using trunk build 2002041803 and profiles created with older build- I set pref 
singleProfileOnly to true and got the following results- as expected

single profile, pref is enabled and reg key set 
launch and test, systray icon appears and process can be seen in task manager.
did usual turbo testing- closed app and systray icon remained as did process

multiple profiles: pref is enabled and reg key set from installation checkbox
launch and test, systray icon appears and process can be seen in task manager.
closed app and systray icon was removed as was process.  reg key still set.  On
next launch of same or different profile, systray icon returned with the process

so with this pref set, QuickLaunch (aka Turbo)settings as reg key and pref will
remain set, but the app will shut down when multiple profiles are present

Comment 17

16 years ago
adding adt1.0.0+ assuming that this bug is needed with the plan to have turbo
shut down and spawn a new process on exit.

If it is then please check this in as soon as possible and add the fixed1.0.0
keyword.
Keywords: adt1.0.0 → adt1.0.0+

Comment 18

16 years ago
I don't think it should be needed for spawn/shutdown, this is our worst-case
fallback option.

Comment 19

16 years ago
Hasn't this already landed on trunk and branch?  Do we just need to set the pref
to resolve it?

Comment 20

16 years ago
Grace, how thoroughly has this been tested?
Keywords: qawanted

Comment 21

16 years ago
I have not seen notification that this has landed on branch- (fixed1.0.0 
keyword) 
I did test on trunk (comment 16) using the basic functional tests and other 
tests listed on http://slip/projects/machv/turboindex.html

(Assignee)

Comment 22

16 years ago
fix checked in, trunk and branch

We'll use another bug to check in the all.js change to turn the pref on.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
Whiteboard: [ADT1] [ETA 4/16] → [ADT1]

Comment 23

16 years ago
verified on trunk (when I set pref) 2002043003
verified on branch 2002043006- pref set in bug 141068
Status: RESOLVED → VERIFIED
Keywords: fixed1.0.0 → verified1.0.0
Component: QuickLaunch (AKA turbo mode) → QuickLaunch (AKA turbo mode)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.