136940 - Exit QuickLaunch mode on last window closing if multiple profiles

Status: VERIFIED FIXED

(Core Graveyard :: QuickLaunch (AKA turbo mode), defect, P1)

Description

[Bill Law]

We decided to implement new code that will run when in Quick Launch mode.  This
code will check, at last window closing, whether the user has multiple profiles
defined and if so, automatically exit QuickLaunch mode (and since the last
window is closing, exit Mozilla).

This code will be enabled via a pref that will default to "off."  The plan is to
change this default to "on" (or remove the pref check) if we are unable to get
QuickLaunch working reliably in multi-profile cases.

Comment 1

[Bill Law]

Nominating

Comment 2

[Peter Trudelle]

nsbeta1+/ADT1

Comment 3

[Bill Law]

Attachment: fix

Comment 4

[Bill Law]

Fix is already attached, just needs reviews/approval.

Comment 5

[Stephen P. Morse]

Comment on attachment 78870 [details] [diff] [review]
fix

r=morse

Comment 6

[Blake Ross]

Comment on attachment 78870 [details] [diff] [review]
fix

Looks good. sr=blake

Comment 7

[Jaime Rodriguez, Jr.]

Adding adt1.0.0. Pls land this on the trunk tonight, and have grace verify that
it is resolved and causes no regressions.

Comment 8

[Bill Law]

Landed on trunk.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78870 [details] [diff] [review]
fix

a=[e-mail]

Comment 10

[Jaime Rodriguez, Jr.]

grace - is this fixed on the trunk? where ther any regressions introduced?

Comment 11

[Grace Bush]

I am waiting for a trunk build for 4/17- this says checked in on 4/16 at 8pm- no 
build since then

Comment 12

[(not reading, please use [e-mail] instead)]

shouldn't we be defaulting "browser.turbo.singleProfileOnly" to true in all.js?

Comment 13

[Bill Law]

Seth: the plan is to do that if and when we have to give up on fixing the
various multi-profile bugs.  I don't think we're at that point yet.

Comment 14

[Peter Trudelle]

We have give it our best shot, but if we do flip that switch, we need to do so
in time to get adequate testing.

Comment 15

[Jaime Rodriguez, Jr.]

Agreed, we don't believe we are the point to give up on Multiple Profile QL
right now. 

Comment 16

[Grace Bush]

using trunk build 2002041803 and profiles created with older build- I set pref 
singleProfileOnly to true and got the following results- as expected

single profile, pref is enabled and reg key set 
launch and test, systray icon appears and process can be seen in task manager.
did usual turbo testing- closed app and systray icon remained as did process

multiple profiles: pref is enabled and reg key set from installation checkbox
launch and test, systray icon appears and process can be seen in task manager.
closed app and systray icon was removed as was process.  reg key still set.  On
next launch of same or different profile, systray icon returned with the process

so with this pref set, QuickLaunch (aka Turbo)settings as reg key and pref will
remain set, but the app will shut down when multiple profiles are present

Comment 17

[scottputterman]

adding adt1.0.0+ assuming that this bug is needed with the plan to have turbo
shut down and spawn a new process on exit.

If it is then please check this in as soon as possible and add the fixed1.0.0
keyword.

Comment 18

[Peter Trudelle]

I don't think it should be needed for spawn/shutdown, this is our worst-case
fallback option.

Comment 19

[Peter Trudelle]

Hasn't this already landed on trunk and branch?  Do we just need to set the pref
to resolve it?

Comment 20

[Peter Trudelle]

Grace, how thoroughly has this been tested?

Comment 21

[Grace Bush]

I have not seen notification that this has landed on branch- (fixed1.0.0 
keyword) 
I did test on trunk (comment 16) using the basic functional tests and other 
tests listed on http://slip/projects/machv/turboindex.html

Comment 22

[Bill Law]

fix checked in, trunk and branch

We'll use another bug to check in the all.js change to turn the pref on.

Comment 23

[Grace Bush]

verified on trunk (when I set pref) 2002043003
verified on branch 2002043006- pref set in bug 141068