1369476 - PushEvent is not fired in e10s mode when there are no content processes running

Status: NEW

(Core :: DOM: Service Workers, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

We should start a process in this case:

https://dxr.mozilla.org/mozilla-central/source/dom/push/PushNotifier.cpp#278

We can use this method:

ContentParent::GetNewOrUsedBrowserProcess()

Currently we basically just ignore push events on mac when firefox is open, but we have no content processes because all the windows have been closed.

I feel like there is already a bug on this, but I can't find it.

Comment 1

[Andrew Overholt [:overholt]]

We should fix this. When does it occur? Only having about:<something> open? On macOS when you have all windows closed but Firefox is still running?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Macos with no windows is the main case I'm aware of.

Comment 3

[Cătălin Badea (:catalinb)]

Having just private browsing windows and receiving push messages might be affected by this bug on other platforms.

Anyhow, fixing this would require being able to keep content processes running for SW instances. To do that we need some sort of abstraction over windows and workers that are considered for the lifetime of a ContentParent. I thought Ben's client patches partially address this - can we fix this now without resorting to a hack?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Oh right.  Its not just starting the process, but keeping it alive.  This probably needs to wait for our multi-e10s refactor.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information