get_output_from_command is reading the output file even if return_type != 'output' and silent=True

RESOLVED FIXED

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: marco, Assigned: marco)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
When return_type != 'output' and silent=True, we can skip reading the output file.
Assignee

Updated

2 years ago
Blocks: 1367763
Assignee

Comment 1

2 years ago
It doesn't actually block bug 1367763, but it's nice to have to spare some resources.
Assignee

Comment 2

2 years ago
Posted patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8874132 - Flags: review?(aki)

Comment 4

2 years ago
Comment on attachment 8874132 [details] [diff] [review]
Patch

makes sense.
Attachment #8874132 - Flags: review?(aki) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a45f5c74d5a
Avoid reading output file in get_output_from_command when it is not needed. r=aki
Keywords: checkin-needed

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2a45f5c74d5a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.