Closed Bug 1369523 Opened 3 years ago Closed 3 years ago

get_output_from_command is reading the output file even if return_type != 'output' and silent=True

Categories

(Release Engineering :: Applications: MozharnessCore, enhancement)

enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
Tracking Status
firefox55 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

When return_type != 'output' and silent=True, we can skip reading the output file.
It doesn't actually block bug 1367763, but it's nice to have to spare some resources.
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8874132 - Flags: review?(aki)
Comment on attachment 8874132 [details] [diff] [review]
Patch

makes sense.
Attachment #8874132 - Flags: review?(aki) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a45f5c74d5a
Avoid reading output file in get_output_from_command when it is not needed. r=aki
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2a45f5c74d5a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.