Closed
Bug 1369536
Opened 8 years ago
Closed 8 years ago
Manually manage the js::vtune::VTuneMutex lifetime
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: fitzgen, Assigned: fitzgen)
References
Details
Attachments
(1 file)
|
3.72 KB,
patch
|
jonco
:
review+
|
Details | Diff | Splinter Review |
We shouldn't be using types with constructors and/or destructors as static
variables because the time of construction/destruction is hard to determine,
which leads to bugs. Instead, we should manage these things manually from
JS_Init and JS_Shutdown.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8873631 -
Flags: review?(jcoppeard)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → nfitzgerald
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Updated•8 years ago
|
Attachment #8873631 -
Flags: review?(jcoppeard) → review+
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d0d6d7cf7c1
Manually manage the js::vtune::VTuneMutex lifetime; r=jonco
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•