Manually manage the js::vtune::VTuneMutex lifetime

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: fitzgen, Assigned: fitzgen)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

We shouldn't be using types with constructors and/or destructors as static
variables because the time of construction/destruction is hard to determine,
which leads to bugs. Instead, we should manage these things manually from
JS_Init and JS_Shutdown.
Assignee: nobody → nfitzgerald
Attachment #8873631 - Flags: review?(jcoppeard) → review+

Comment 3

2 years ago
Pushed by nfitzgerald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d0d6d7cf7c1
Manually manage the js::vtune::VTuneMutex lifetime; r=jonco

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d0d6d7cf7c1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.