1369551 - Remove unused release mozconfigs for fennec

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Nick Thomas [:nthomas] (UTC+12)]

In bug 1369279 comment #4 I learned we don't use the release or l10n-release mozconfigs any more, so we should remove them to avoid confusion. Also present in the merge day configs.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: Bug 1369551 - Remove unused release mozconfigs for fennec,

* removes old files mobile/android/config/mozconfigs/*/{release,l10n-release}
* updates merge day scripts (did some config dumping to verify, but didn't run migration)
* updates testing/mozharness/configs/single_locale/{staging_,}mozilla-{beta,release}_android-api-15.py to remove bogus mozconfig definition, which now comes from single_locale/tc_android-api-15.py

I could go on and look at configs/multi_locale, which appear to be unused, but I've got to draw a line somewhere.

Review commit: https://reviewboard.mozilla.org/r/145044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145044/

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8873655 [details]
Bug 1369551 - Remove unused release mozconfigs for fennec,

https://reviewboard.mozilla.org/r/145044/#review149094

::: testing/mozharness/configs/merge_day/beta_to_release.py:25
(Diff revision 1)
>      ] + [
>          # File, from, to
> -        ("{}/{}".format(d, f),
> +        (f, "ac_add_options --with-l10n-base=../../mozilla-beta",
> -        "ac_add_options --with-l10n-base=../../mozilla-beta",
>          "ac_add_options --with-l10n-base=../../mozilla-release")
> -        for d in ["mobile/android/config/mozconfigs/android-api-15/",
> +        for f in ["mobile/android/config/mozconfigs/android-api-15/l10n-nightly",

Noob question: shouldn't we have some reference to android-aarch64 somewhere around here?

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8873655 [details]
Bug 1369551 - Remove unused release mozconfigs for fennec,

https://reviewboard.mozilla.org/r/145044/#review151036

::: testing/mozharness/configs/merge_day/beta_to_release.py:25
(Diff revision 1)
>      ] + [
>          # File, from, to
> -        ("{}/{}".format(d, f),
> +        (f, "ac_add_options --with-l10n-base=../../mozilla-beta",
> -        "ac_add_options --with-l10n-base=../../mozilla-beta",
>          "ac_add_options --with-l10n-base=../../mozilla-release")
> -        for d in ["mobile/android/config/mozconfigs/android-api-15/",
> +        for f in ["mobile/android/config/mozconfigs/android-api-15/l10n-nightly",

Yes we should. I filed bug 1371099 for that, since it's more of an oversight in adding aarch64 than a problem with this patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c745f0c2216
Remove unused release mozconfigs for fennec, r=mtabara

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9c745f0c2216