Closed Bug 1369551 Opened 3 years ago Closed 3 years ago

Remove unused release mozconfigs for fennec

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
Tracking Status
firefox55 --- fixed

People

(Reporter: nthomas, Assigned: nthomas)

Details

Attachments

(1 file)

In bug 1369279 comment #4 I learned we don't use the release or l10n-release mozconfigs any more, so we should remove them to avoid confusion. Also present in the merge day configs.
Comment on attachment 8873655 [details]
Bug 1369551 - Remove unused release mozconfigs for fennec,

https://reviewboard.mozilla.org/r/145044/#review149094

::: testing/mozharness/configs/merge_day/beta_to_release.py:25
(Diff revision 1)
>      ] + [
>          # File, from, to
> -        ("{}/{}".format(d, f),
> +        (f, "ac_add_options --with-l10n-base=../../mozilla-beta",
> -        "ac_add_options --with-l10n-base=../../mozilla-beta",
>          "ac_add_options --with-l10n-base=../../mozilla-release")
> -        for d in ["mobile/android/config/mozconfigs/android-api-15/",
> +        for f in ["mobile/android/config/mozconfigs/android-api-15/l10n-nightly",

Noob question: shouldn't we have some reference to android-aarch64 somewhere around here?
Attachment #8873655 - Flags: review?(mtabara) → review+
Comment on attachment 8873655 [details]
Bug 1369551 - Remove unused release mozconfigs for fennec,

https://reviewboard.mozilla.org/r/145044/#review151036

::: testing/mozharness/configs/merge_day/beta_to_release.py:25
(Diff revision 1)
>      ] + [
>          # File, from, to
> -        ("{}/{}".format(d, f),
> +        (f, "ac_add_options --with-l10n-base=../../mozilla-beta",
> -        "ac_add_options --with-l10n-base=../../mozilla-beta",
>          "ac_add_options --with-l10n-base=../../mozilla-release")
> -        for d in ["mobile/android/config/mozconfigs/android-api-15/",
> +        for f in ["mobile/android/config/mozconfigs/android-api-15/l10n-nightly",

Yes we should. I filed bug 1371099 for that, since it's more of an oversight in adding aarch64 than a problem with this patch.
Pushed by nthomas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9c745f0c2216
Remove unused release mozconfigs for fennec, r=mtabara
https://hg.mozilla.org/mozilla-central/rev/9c745f0c2216
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.