1369564 - [Photon] Menus are too wide.

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P1)

Description

[Gary [:streetwolf52]]

Attachment: Wide Menu example

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170601135542

Steps to reproduce:

Seems that some patch on inbound has just about doubled the width of menus of non-firefox icons on the toolbar. This makes almost half of the menu white space. The last good cset is 001d49708a35. The bad one is e398680c4833. 

I have Photon turned on btw.


Actual results:

Menus from non-Fx icons on toolbar are too wide.


Expected results:

Menus should be normal width.

Comment 1

[Gary [:streetwolf52]]

Attachment: Wide Menu example

Fixed image.

Comment 2

[Gary [:streetwolf52]]

This is a Photon issue.  I set 'browser.photon.structure.enabled' to false and the menus were fine.

Comment 3

[Gary [:streetwolf52]]

Not all add-on menus off of their icon are too wide.  On my system uBlock Origin, Zoom Page WE, and partially Text Cache Lite are too wide. My other add-on icon menus look fine.

Comment 4

[atlanto]

mozregression tells
 2:58.08 INFO: Last good revision: bdb2387396b4a74dfefb7c983733eed3625e906a
 2:58.08 INFO: First bad revision: d96110d766199d42524558fd83e6467906de4daf
 2:58.08 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bdb2387396b4a74dfefb7c983733eed3625e906a&tochange=d96110d766199d42524558fd83e6467906de4daf

I believe bug 1354155 introduced the regression.

https://hg.mozilla.org/mozilla-central/rev/27e39a0dead1#l5.48
>+      let multiView = document.createElement(gPhotonStructure ? "photonpanelmultiview" : "panelmultiview");

and

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#346
>photonpanelmultiview panelview {
>  background: var(--arrowpanel-background);
>  padding: 6px 0;
>  min-width: @menuPanelWidth@;
>}

So, if I applied small value (or "auto") to min-width, the panel is recovered.
>photonpanelmultiview panelview {
>  min-width: 0;
>}

(tested with nightly build 20170603030204 and uBlock Origin 1.12.4, Stylish 2.0.7)
(is that really *min*-width?)

Comment 5

[:Gijs (out for now; he/him)]

Comment on attachment 8873647 [details]
Wide Menu example

This image seems to be broken?

Comment 6

[:Gijs (out for now; he/him)]

The min-width itself was added in bug 1363753. I'm not sure to what degree it's necessary in all panels, or if this selector should have just applied to the main hamburger panel - in which case, I wonder if we'll need to set a min-width on some of the other panels manually to avoid similar bugs as mentioned in bug 1363753 happening. Maybe Mike knows.

Comment 7

[Mike de Boer [:mikedeboer]]

I'll take a look at this.

Comment 8

[:Gijs (out for now; he/him)]

I put up a patch in bug 1354109 that addresses it (as webextensions tests fail otherwise).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d39d7663a53b
fix min-width issues with panels, r=mikedeboer

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d39d7663a53b

Comment 11

[u554753]

Verified on Windows, Mac, and Ubuntu.