Closed Bug 1369586 Opened 3 years ago Closed 3 years ago

Give grid area name text a background and rounded border

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: micah, Assigned: micah)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

We want to give area name text displayed in the grid area overlay a white background and a rounded border so that the text is easier to identify.
Assignee: nobody → tigleym
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8874072 [details]
Bug 1369586 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145532/#review149810
Attachment #8874072 - Flags: review?(gl) → review+
Attached patch 1369586.patchSplinter Review
Attachment #8874072 - Attachment is obsolete: true
Attachment #8874509 - Flags: review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60bbd8e76c33
Add a border around the grid area name overlay. r=gl
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a312474c646c
Fix eslint error with 'currentZoom' variable never being used in css-grid.js. r=me
https://hg.mozilla.org/mozilla-central/rev/60bbd8e76c33
https://hg.mozilla.org/mozilla-central/rev/a312474c646c
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8874072 [details]
Bug 1369586 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145532/#review151602

Landed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.