Give grid area name text a background and rounded border

RESOLVED FIXED in Firefox 55

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: micah, Assigned: micah)

Tracking

(Blocks 1 bug)

unspecified
Firefox 55
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
We want to give area name text displayed in the grid area overlay a white background and a rounded border so that the text is easier to identify.
(Assignee)

Updated

2 years ago
Assignee: nobody → tigleym
(Assignee)

Updated

2 years ago
Status: NEW → ASSIGNED
Priority: -- → P3
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8874072 [details]
Bug 1369586 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145532/#review149810
Attachment #8874072 - Flags: review?(gl) → review+
Posted patch 1369586.patchSplinter Review
Attachment #8874072 - Attachment is obsolete: true
Attachment #8874509 - Flags: review+

Comment 4

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60bbd8e76c33
Add a border around the grid area name overlay. r=gl

Comment 5

2 years ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a312474c646c
Fix eslint error with 'currentZoom' variable never being used in css-grid.js. r=me

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/60bbd8e76c33
https://hg.mozilla.org/mozilla-central/rev/a312474c646c
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8874072 [details]
Bug 1369586 - Use new colours for the grid cell and area fills.

https://reviewboard.mozilla.org/r/145532/#review151602

Landed

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.