1369677 - Handle the SHMEM map-failed with WR

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Some canvas tests create a large shmem buffer and the parent side might not be able to map that large buffer.

The log will be:
###!!! [Parent][DispatchAsyncMessage] Error: SHMEM_CREATED_MESSAGE Payload error: message could not be deserialized
[GFX1-]: Failed to create a valid ShmemTextureHost

There is no problem for gecko with this situation. The gecko just skips the rendering call for that bad buffer. But with WR, we already put the display items at client side. We can't cancel the display item rendering at parent side. So, we will hit some crash when we try to map that bad-shmem during rendering.

I plan to skip the mapping call for the bad-shmem, and bypass the nullptr to WR. Then, provide a whole black buffer(rgba(0,0,0,0)) or a 0 gl handle in the wr-binding. We will see a black area for that bad-shmem display item.

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: handle RenderTexture lock() failed.

MozReview-Commit-ID: Ghez1SJ6ghf

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the Attachment #8903095 [details] [diff] to m-c.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3442318a1024
Handle RenderTexture lock() failed. r=nical

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3442318a1024