1369694 - [TSF] TSFTextStore shouldn't cache pref until first use

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement, P2)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23600b47e83e3cf0ae1d79d1f8372b263651d5f4

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1369694 Create TSFPrefs class and make it cache each pref at first use

Getting all prefs for TSFTextStore during initializing may make damage to start up performance.

So, each one should be retrieved when the one is actually necessary.

This patch creates TSFPrefs (I like better to name it TSFPreferences, but such long name isn't better when calling long name methods.) and implemented by simple macro.

Review commit: https://reviewboard.mozilla.org/r/147982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147982/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I tested disabled state of each test. However, I couldn't see issues for some prefs. I think that we should investigate and sort out them when we have much time to work on them.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=063c5850f99c582d0319e7a99db99001dd4ae5c0

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8876641 [details]
Bug 1369694 Create TSFPrefs class and make it cache each pref at first use

https://reviewboard.mozilla.org/r/147982/#review152644

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53cd12ec3113
Create TSFPrefs class and make it cache each pref at first use r=m_kato

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/53cd12ec3113