[TSF] ITfMessagePump and ITfKeystrokeMgr shouldn't be QIed from ThreadMgr until first use

RESOLVED FIXED in Firefox 56

Status

()

Core
Widget: Win32
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({inputmethod})

Trunk
mozilla56
All
Windows
inputmethod
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [qf:p1][tpi:+])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

Comment hidden (empty)

Updated

2 months ago
Priority: -- → P2
Whiteboard: [qf:p1][tpi:+]
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5172d58b333b895bebe22e3bef1121e576bcbcb
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b31c30034bb8a01a08de2260c5ae94d57809dbd3
(Assignee)

Updated

2 months ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Looks like no perf regression:

part1: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=6f6883c950cb&newProject=try&newRevision=cc2b6782fb3c&framework=1&showOnlyImportant=0
part2: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=6f6883c950cb&newProject=try&newRevision=7469639e8770&framework=1&showOnlyImportant=0

The latter shows some slowness only on x86 build, but they disappeared checking with additional patch for another bug: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=6f6883c950cb&newProject=try&newRevision=e908cc391657&framework=1&showOnlyImportant=0

And according to the graph,
https://treeherder.mozilla.org/perf.html#/graphs?highlightedRevisions=6f6883c950cb&highlightedRevisions=7469639e8770&series=%5B%22try%22,%22dfac9bac6ca266e9075c959c581774267e881d26%22,1,1%5D&timerange=86400
https://treeherder.mozilla.org/perf.html#/graphs?highlightedRevisions=6f6883c950cb&highlightedRevisions=7469639e8770&series=%5B%22try%22,%22bf3413f2f08733f70710103dc0827f715b51ce08%22,1,1%5D&timerange=86400

These two reds are caused by too fast result of the base revision.

And according to this graph,
https://treeherder.mozilla.org/perf.html#/graphs?highlightedRevisions=6f6883c950cb&highlightedRevisions=7469639e8770&series=%5B%22try%22,%22456abe18d122f7a723b75aef5ed9c175481735c6%22,1,1%5D&timerange=86400

The orange result of new revision isn't so slow comparing with other results.

So, they just hit random result.

Comment 6

2 months ago
mozreview-review
Comment on attachment 8877426 [details]
Bug 1369696 - part 1: TSFTextStore::sKeystrokeMgr should be QIed from TSFTextStore::sThreadMgr at first use

https://reviewboard.mozilla.org/r/148818/#review153422
Attachment #8877426 - Flags: review?(m_kato) → review+

Comment 7

2 months ago
mozreview-review
Comment on attachment 8877427 [details]
Bug 1369696 - part 2: TSFTextStore::sMessagePump should be QIed from TSFTextStore::sThreadMgr at first use

https://reviewboard.mozilla.org/r/148820/#review153426
Attachment #8877427 - Flags: review?(m_kato) → review+

Comment 8

2 months ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/96172f97bf0c
part 1: TSFTextStore::sKeystrokeMgr should be QIed from TSFTextStore::sThreadMgr at first use r=m_kato
https://hg.mozilla.org/integration/autoland/rev/ec9869a14c67
part 2: TSFTextStore::sMessagePump should be QIed from TSFTextStore::sThreadMgr at first use r=m_kato
https://hg.mozilla.org/mozilla-central/rev/96172f97bf0c
https://hg.mozilla.org/mozilla-central/rev/ec9869a14c67
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.