1369702 - Tab Reorder - dragging tab to empty space in the last row doesn't move the tab

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Ioana Chiorean]

Steps:
1. Have several tabs open
2. Open tabs view 
3. Try to move one tab to the bottom or near the last tab ( in the right part of it) 

Expected Results:
- The tab should be moved to the last position

Actual Results:
- The tab will be bounced back

See video: https://youtu.be/aFJmb8i9-Ok

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

The video seems to be for Bug 1369701 ?

Comment 2

[Tom Klein]

The video in comment 0 is showing expected behavior for the way Android's (default) implementation of RecyclerView drag and drop works.  If you want to move tab A to tab B, and tab B is in a row below tab A, then you need to drag tab A to a point where it overlaps the bottom of tab B.  In general, in order to move a tab, the tab you're moving has to overlap the tab you're moving to in some way, so in that sense the case in this bug (trying to move a tab to the last position) works the same as all other moves.

Video of moves to the last tab: https://youtu.be/AaPfHvKgQ6g

I'm marking as invalid since moving to the last position is working as expected (that is, given the way Android has implemented drag-and-drop for RecyclerView) for me and in the video, but if being able to drop a tab in the empty space in the last row and have it become the last tab is considered required (or desired) behavior then please reopen.

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

NI Jack to look at this from UX perspective.

Comment 4

[Jack Lin[:jacklin]]

For UX perspective, I think "users are able to drop a tab in the empty space in the last row and have it become the last tab" is intuitive and easy to rearrange the tabs. But honestly, this implementation is launched for a while and haven't received users complains about this. So I don't think we should improve this at this moment. 

This is my thought. How do you think?

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Agree. This is more like a nice-to-have improvement which shouldn't block shipping.