1369719 - Preferences search shows matched in sub-dialogs when searching numbers

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170602100143 CSet: aeb3d0ca558f034cbef1c5a68bd07dd738611494

STR:
1) Open about:preferences with search enabled.
2) Type in "0" or "1".
3) See where the search found the number (mostly in combo box menus, like what to do when Firefox starts).

Comment 1

[Ricky Chien [:rickychien] (inactive)]

In short, we search algorithm will try to match every keyword appears in node's "label" and "value" attributes. The combo box menus a.k.a dropdown menu uses value = 0,1,2...etc to indicate the order of each item in menu, which causes unexpected result we don't want.

We should tweak the search algorithm to skip searching value attribute when element is dropdown menu.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1369719 - Avoid searching value attribute in menuitem

Review commit: https://reviewboard.mozilla.org/r/145656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145656/

Comment 3

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Comment on attachment 8874289 [details]
Bug 1369719 - Avoid searching value attribute in menuitem

https://reviewboard.mozilla.org/r/145656/#review149788

::: browser/components/preferences/in-content-new/findInPage.js:300
(Diff revision 1)
>        // Creating tooltips for buttons
>        if (labelResult && nodeObject.tagName === "button") {
>          this.listSearchTooltips.push(nodeObject);
>        }
>  
>        // Searching some elements, such as xul:label, store their user-visible text in a "value" attribute.

Let's add a comment here about why we're skipping menuitem values.

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8874289 [details]
Bug 1369719 - Avoid searching value attribute in menuitem

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145656/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a10169452a5
Avoid searching value attribute in menuitem r=mconley

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3a10169452a5

Comment 7

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Cannot reproduce in the build today anymore. Thank for fixing.

Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 ID:20170606100219 CSet: 58ce95bc58ce4ba200413c8bed87786dccf3d105

Comment 8

[Hani Yacoub, Desktop QA]

Build ID: 20170612091112
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.