Closed
Bug 1369741
Opened 8 years ago
Closed 8 years ago
wasm: Rename MaybeActiveActivation
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
References
Details
Attachments
(1 file)
|
8.12 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
As discussed in bug 1367871 comment 21 and 22. Spawned a different bug because tracking/uplifting expectations are different.
I've chosen "MaybeInnermostActiveActivation" because "MaybeActiveInnermostActivation" seemed unnatural, but who am I to know about adjectives order in English [1].
[1] https://twitter.com/mattandersonbbc/status/772002757222002688
Attachment #8873861 -
Flags: review?(luke)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8873861 [details] [diff] [review]
rename.patch
Review of attachment 8873861 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for fixing this! I'm still not certain this name conveys that the function "stops trying" at the first active activation. What about wasm::ActivationIfInnermost()?
Attachment #8873861 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ce7741f59b6
Rename wasm::MaybeActiveActivation to wasm::ActivationIfInnermost; r=luke
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•