1369781 - balrog submission tools should submit as json

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), enhancement, P1)

Description

[[e-mail] (:bhearsum)]

After we landed part of https://bugzilla.mozilla.org/show_bug.cgi?id=1336452 we had some bustage that boiled down to the fact that the new swagger endpoints were requiring json encoded data in the body, but the balrogclient tools were sending form data. It turns out that swagger doesn't allow you to accept both for the same endpoint. JSON is really what we want to use, so we should switch the client tools to that.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: submit json to balrog

Comment 2

[[e-mail] (:bhearsum)]

Attachment: import new version of balrogclient to tools repo

Comment 3

[[e-mail] (:bhearsum)]

Also need to add balrogclient-0.0.3.tar.gz to puppet, and bump the version for balrog_scriptworker. AFAIK I can do that with r=versionbump.

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

Comment on attachment 8873934 [details] [diff] [review]
import new version of balrogclient to tools repo

Review of attachment 8873934 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me

Comment 5

[Simon Fraser [:sfraser] ⌚️GMT]

My review on github doesn't mean much since I don't have write access to the repo, but the change looks good

Comment 6

[[e-mail] (:bhearsum)]

I'm going to hold off on landing the tools patch until we're clear of Beta 1 (June 14th/15th).

Comment 7

[[e-mail] (:bhearsum)]

Comment on attachment 8873900 [details] [review]
submit json to balrog

This was r+'ed in github.

Comment 8

[[e-mail] (:bhearsum)]

Comment on attachment 8873934 [details] [diff] [review]
import new version of balrogclient to tools repo

I pushed this + the minor fix from bug 1372918 just now. I'll bump the version in Puppet shortly.

Comment 9

[[e-mail] (:bhearsum)]

This is rolling out to balrog scriptworker now.

Comment 10

[[e-mail] (:bhearsum)]

Rail, I need funsize to pick up this change to the submission tools. Can you help with that, or point me in the right direction?

Comment 11

[[e-mail] (:bhearsum)]

(In reply to Ben Hearsum (:bhearsum) from comment #10)
> Rail, I need funsize to pick up this change to the submission tools. Can you
> help with that, or point me in the right direction?

Hm, I think this is no longer necessary now that we're using balrog scriptworker actually...

Comment 12

[Rail Aliiev [:rail]]

Hmm, probably we still to refresh the image at https://github.com/mozilla-releng/funsize/blob/master/funsize/tasks/funsize.yml#L169

Comment 13

[Rail Aliiev [:rail]]

Opened a PR: https://github.com/mozilla-releng/funsize/pull/59
After it's merged, we need to bump the version and deploy it.