Closed Bug 1369803 Opened 3 years ago Closed 3 years ago

Potential crash under ScriptSource::xdrEncodeFunction

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

Details

Attachments

(1 file)

As mentioned in Bug 1368992 comment 5, we might have nullptr-SEGV crashes if we OOM under JS::StartIncrementalEncoding, or failed to encode the top-level JSScript.
Attachment #8873909 - Flags: review?(shu)
Attachment #8873909 - Flags: review?(shu) → review+
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd90d75e1b51
Allow FinishIncrementalEncoding call even if StartIncrementalEncoding call failed. r=shu
https://hg.mozilla.org/mozilla-central/rev/fd90d75e1b51
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → nicolas.b.pierron
You need to log in before you can comment on or make changes to this bug.