1369824 - Pref Screenshots off in Beta/Release

Status: RESOLVED FIXED

(Firefox :: Screenshots, enhancement)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

We're going to gradually roll out Screenshots in releases other than Nightly, so let's conditionally pref it off in those platforms.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1369824 - Pref Screenshots off in beta and release;

Review commit: https://reviewboard.mozilla.org/r/145308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145308/

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Tests are green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4e30078f6e9b0193eb4d960483c40c1f08dd07e

Setting checkin-needed

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Oops! Updated the wrong bug.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8873931 [details]
Bug 1369824 - Pref Screenshots off in beta and release;

https://reviewboard.mozilla.org/r/145308/#review149492

::: browser/app/profile/firefox.js:1688
(Diff revision 1)
> +#ifdef NIGHTLY_BUILD
> +pref("extensions.screenshots.system-disabled", false);
> +#else
> +pref("extensions.screenshots.system-disabled", true);
> +#endif
> +pref("extensions.screenshots.system-disabled", true);

This looks wrong?

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8873931 [details]
Bug 1369824 - Pref Screenshots off in beta and release;

Cancelling whilst waiting for an update.

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8873931 [details]
Bug 1369824 - Pref Screenshots off in beta and release;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145308/diff/1-2/

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8873931 [details]
Bug 1369824 - Pref Screenshots off in beta and release;

https://reviewboard.mozilla.org/r/145308/#review151336

That's better, thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b86fec2a2ed8
Pref Screenshots off in beta and release; r=standard8

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b86fec2a2ed8