Closed
Bug 1369824
Opened 7 years ago
Closed 7 years ago
Pref Screenshots off in Beta/Release
Categories
(Firefox :: Screenshots, enhancement)
Firefox
Screenshots
Tracking
()
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
Attachments
(1 file)
We're going to gradually roll out Screenshots in releases other than Nightly, so let's conditionally pref it off in those platforms.
Assignee | ||
Updated•7 years ago
|
Blocks: firefox-screenshots
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jhirsch
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
Tests are green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4e30078f6e9b0193eb4d960483c40c1f08dd07e Setting checkin-needed
Keywords: checkin-needed
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8873931 [details] Bug 1369824 - Pref Screenshots off in beta and release; https://reviewboard.mozilla.org/r/145308/#review149492 ::: browser/app/profile/firefox.js:1688 (Diff revision 1) > +#ifdef NIGHTLY_BUILD > +pref("extensions.screenshots.system-disabled", false); > +#else > +pref("extensions.screenshots.system-disabled", true); > +#endif > +pref("extensions.screenshots.system-disabled", true); This looks wrong?
Comment 5•7 years ago
|
||
Comment on attachment 8873931 [details] Bug 1369824 - Pref Screenshots off in beta and release; Cancelling whilst waiting for an update.
Attachment #8873931 -
Flags: review?(standard8)
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8873931 [details] Bug 1369824 - Pref Screenshots off in beta and release; https://reviewboard.mozilla.org/r/145308/#review151336 That's better, thanks!
Attachment #8873931 -
Flags: review?(standard8) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b86fec2a2ed8 Pref Screenshots off in beta and release; r=standard8
Updated•7 years ago
|
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•