136985 - Expose support for detecting unrequested popups.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[David Hyatt]

I'm implementing a feature in Chimera to pose a popup blocker dialog.  This 
involves needing access to the same logic used in nsGlobalWindow.cpp, namely !
mIsDocumentLoading || mRunningTimeout.

This need not be exposed in anything more than a private API.

Comment 1

[David Hyatt]

Attachment: Expose logic on nsPIDOMWindow

Comment 2

[David Hyatt]

Need r/sr for trunk only.  This isn't going on the branch.

Comment 3

[David Hyatt]

Ignore the extra braces.  I already removed those.

Comment 4

[Blake Ross]

Comment on attachment 78793 [details] [diff] [review]
Expose logic on nsPIDOMWindow

sr=blake provided jst is ok with it

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 78793 [details] [diff] [review]
Expose logic on nsPIDOMWindow

r=jst

Comment 6

[Robert Ginda]

We added a pref to disable window.open |n| milliseconds after a mouse click too.
 Do you need that as well, or can you figure that out yourself?

Comment 7

[David Hyatt]

Fixed.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78793 [details] [diff] [review]
Expose logic on nsPIDOMWindow

approval for branch as requested by ccarlen.  CHange mozilla1.0.1+ to
fixed1.0.1 when checked in.

Comment 9

[Conrad Carlen (not reading bugmail)]

Checked into branch.