Closed Bug 1369855 Opened 4 years ago Closed 4 years ago
.js to version 2 .3 .2
At the moment we are using sinon-1.16.1.js We rely a lot on mocks in Sync testing code, and this old version of sinon.js doesn't mock getters.
Comment on attachment 8874970 [details] Bug 1369855 - Update sinon.js to version 2.3.2. Sorry I wasn't really sure who to ask for review so I just went with what the "suggest reviewers" popup suggested.
Attachment #8874970 - Flags: review?(ahalberstadt)
Hey no worries, though I'm not a good reviewer for this. Looks like :markh reviewed the patch that added sinon in the first place, so maybe he'd be a good candidate (or at least have a better idea who to re-direct this to).
Attachment #8874970 - Flags: review?(ahalberstadt) → review?(markh)
Failing tests fixed
Comment on attachment 8874970 [details] Bug 1369855 - Update sinon.js to version 2.3.2. https://reviewboard.mozilla.org/r/145394/#review151068 This looks fine to me, thanks.
Attachment #8874970 - Flags: review?(markh) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d397d4c72d75 Update sinon.js to version 2.3.2. r=markh
You need to log in before you can comment on or make changes to this bug.