Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: dylan, Assigned: umohm12)

Tracking

Production
Dependency tree / graph

Details

Attachments

(2 attachments)

I think it will ease the branding effort (among other things) if we can unify the CSS files.

This would mean appending the content of
https://github.com/mozilla-bteam/bmo/blob/master/skins/custom/index.css
https://github.com/mozilla-bteam/bmo/blob/master/skins/contrib/Mozilla/index.css
(in that order)

to the end of https://github.com/mozilla-bteam/bmo/blob/master/skins/standard/index.css

and so on for all the files under skins/custom and skins/contrib/Mozilla.
(Reporter)

Comment 1

2 years ago
As long as the ordering of the rules in the CSS files is the same, this should have no impact.
After this, it should be possible to use CSS developer tools to remove unneeded CSS rules as well.
(Reporter)

Comment 2

2 years ago
note the ordering is standard, then skin, then custom. 

basically, for each one, concatate together and append to the standard one. Like the shell command below:

cat skins/contrib/Mozilla/index.css skins/custom/index.css >> skins/standard/index.css
Summary: Combine skins/contrib/*.css and skins/custom/Mozilla/*.css into skins/standard/*.css → Combine skins/custom/Mozilla/*.css and skins/contrib/*.css into skins/standard/*.css
(Assignee)

Comment 3

2 years ago
Created attachment 8874542 [details] [review]
PR
Attachment #8874542 - Flags: review?(dylan)
(Reporter)

Updated

2 years ago
Priority: -- → P1
(Reporter)

Updated

2 years ago
Summary: Combine skins/custom/Mozilla/*.css and skins/contrib/*.css into skins/standard/*.css → Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css
(Reporter)

Comment 4

2 years ago
Comment on attachment 8874542 [details] [review]
PR

Changes requested in the pull request.
Attachment #8874542 - Flags: review?(dylan) → review-
(Reporter)

Comment 5

2 years ago
Additional review cycled happened, with only one problem. I'm going to open this up for QA on bugzilla-dev so there are a few more eyes to catch changes.
Created attachment 8878217 [details]
Bug List

I found one small thing, the background color is missing from the bug list header.
(Reporter)

Comment 7

2 years ago
This seems to be the case in production as well -- not a bug?
Flags: needinfo?(ehumphries)
(Reporter)

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Reporter)

Updated

2 years ago
Attachment #8874542 - Flags: review- → review+
(Reporter)

Updated

2 years ago
Summary: Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css → Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css
(Reporter)

Updated

2 years ago
Blocks: 1380019
(Reporter)

Updated

2 years ago
Blocks: 1380064

Updated

4 months ago
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.