Closed Bug 1369872 Opened 3 years ago Closed 3 years ago

Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css

Categories

(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, enhancement, P1)

Production
enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dylan, Assigned: umohm12)

References

Details

Attachments

(2 files)

I think it will ease the branding effort (among other things) if we can unify the CSS files.

This would mean appending the content of
https://github.com/mozilla-bteam/bmo/blob/master/skins/custom/index.css
https://github.com/mozilla-bteam/bmo/blob/master/skins/contrib/Mozilla/index.css
(in that order)

to the end of https://github.com/mozilla-bteam/bmo/blob/master/skins/standard/index.css

and so on for all the files under skins/custom and skins/contrib/Mozilla.
As long as the ordering of the rules in the CSS files is the same, this should have no impact.
After this, it should be possible to use CSS developer tools to remove unneeded CSS rules as well.
note the ordering is standard, then skin, then custom. 

basically, for each one, concatate together and append to the standard one. Like the shell command below:

cat skins/contrib/Mozilla/index.css skins/custom/index.css >> skins/standard/index.css
Summary: Combine skins/contrib/*.css and skins/custom/Mozilla/*.css into skins/standard/*.css → Combine skins/custom/Mozilla/*.css and skins/contrib/*.css into skins/standard/*.css
Attached file PR —
Attachment #8874542 - Flags: review?(dylan)
Priority: -- → P1
Summary: Combine skins/custom/Mozilla/*.css and skins/contrib/*.css into skins/standard/*.css → Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css
Comment on attachment 8874542 [details] [review]
PR

Changes requested in the pull request.
Attachment #8874542 - Flags: review?(dylan) → review-
Additional review cycled happened, with only one problem. I'm going to open this up for QA on bugzilla-dev so there are a few more eyes to catch changes.
Attached image Bug List —
I found one small thing, the background color is missing from the bug list header.
This seems to be the case in production as well -- not a bug?
Flags: needinfo?(ehumphries)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Attachment #8874542 - Flags: review- → review+
Summary: Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css → Combine skins/contrib/Mozilla/*.css and skins/custom/*.css into skins/standard/*.css
Blocks: 1380019
Blocks: 1380064
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.