1369891 - Sync Ping tests failing in automation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, defect)

Description

[:Grisha Kruglov]

Tests failing due to toString comparisons of objects.

https://public-artifacts.taskcluster.net/JGJagcMjQS-m8N7649YzYw/0/public/android/unittest/officialAustralisDebug/index.html

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1369891 - Improve sync ping tests and stop them from failing in automation

Switch to explicit checks of contents of json objects, vs checking against toString output.

Review commit: https://reviewboard.mozilla.org/r/145494/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145494/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8874045 [details]
Bug 1369891 - Improve sync ping tests and stop them from failing in automation

https://reviewboard.mozilla.org/r/145494/#review149428

Fine by me.  EJO defines `.equals()`, which can make this easier.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f5b93b0571a
Improve sync ping tests and stop them from failing in automation r=nalexander

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4f5b93b0571a