1369892 - [findbugs] Sync Ping dodgy casting

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, enhancement)

Description

[:Grisha Kruglov]

https://public-artifacts.taskcluster.net/Jwqr_7I7Sb2rhLzKYqTsyw/0/public/android/findbugs/findbugs-officialAustralisDebug-output.html

findbugs didn't like my casting, and frankly neither do I.

Comment 1

[:Grisha Kruglov]

Attachment: Bug 1369892 - Silence findbugs dodgy casting warning

Strangely enough, this patch seems to appease findbugs.

While dodgy indeed, I think this casting is acceptable in this case since we control
both sides of the equation (sender & receiver of telemetry), but can't easily do away
with casting.

Review commit: https://reviewboard.mozilla.org/r/145482/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145482/

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8874040 [details]
Bug 1369892 - Silence findbugs dodgy casting warning

https://reviewboard.mozilla.org/r/145482/#review149424

Sure.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72ab73cbc5c7
Silence findbugs dodgy casting warning r=nalexander

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/72ab73cbc5c7