1369940 - nsNavBookmarks::GetBookmarkIdsForURITArray() uses synchronous sqlite

Status: RESOLVED DUPLICATE of bug 519514

(Toolkit :: Places, enhancement)

Description

[(no longer active)]

Attachment: trace

I experienced a long UI pause today on my old OSX machine, unfortunately the Gecko Profiler add-on wasn't activated and I wasn't quick enough to open Instruments but I captured a trace in Activity Monitor.

This comes from <https://searchfox.org/mozilla-central/rev/3efd1caff252061946f0773df68bdd50de5eb756/toolkit/components/places/PlacesUtils.jsm#1335> as far as I can tell.

This looks like main-thread IO to me.  Marco, is that right?  Is this bad?  Do we have a bug for it?

Comment 1

[Marco Bonardo [:mak]]

All the synchronous bookmarking APIs are deprecated in favor of bug 519514, the UI conversion is happening gradually though, I didn't have resources for the migration so I worked with volunteers from the community in these months to bring on the work, but some big pieces are still blocked.
I plan to work on that problem soon, once Firefox 55 is done, maybe even as a sprint for the SF all hands.

And yes almost all the UI touching bookmarks is doing main-thread IO, exactly because the resources for the async bookmarking project were all pulled some time ago to work on other projects, and I could never complete it.

I don't know if you want to keep this open or not, bug 519514 already tracks most of the work.

Comment 2

[Marco Bonardo [:mak]]

And bug 979280 is another strict requirement, since the UI goes through the transaction manager, if the transaction manager is synchronous, we can't do much.

Both bookmarks and transactions project are around 70-80% completion.