1369967 - Crash in mozilla::AudioProxyThread::InternalProcessAudioChunk

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[[:philipp]]

This bug was filed from the Socorro interface and is 
report bp-e7667c05-6902-49ce-b406-677120170603.
=============================================================
Crashing Thread (100)
Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::AudioProxyThread::InternalProcessAudioChunk(int, mozilla::AudioChunk&, bool) 	media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:552

this is a low volume crash signature that shows up from windows 7 users starting with firefox 51 and later builds.
most user comments say they where trying to join a facebook video call.

Comment 1

[Nils Ohlmeier [:drno]]

Paul can you please take a look and asses how important this is?

Comment 2

[Paul Adenot (:padenot)]

Rare stack buffer overflow. Patch coming up.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1369967 - Remove one use of a stack-allocated buffer and fix another buffer's size.

Two things here:
- The default stack size of the thread pool is not very big, it's better to
stick the buffer we need on the object.
- There was a unit mismatch between bytes and samples. This changes the name to
make the unit more obvious, and fixes its usage by dividing by the sample size.

Review commit: https://reviewboard.mozilla.org/r/145734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145734/

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8874374 [details]
Bug 1369967 - Remove one use of a stack-allocated buffer and fix another buffer's size.

https://reviewboard.mozilla.org/r/145734/#review149712

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7edfae1ee9dc
Remove one use of a stack-allocated buffer and fix another buffer's size. r=jesup

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7edfae1ee9dc

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This already missed 54 and it doesn't look high-volume enough on ESR52 to worry about backporting there either. Feel free to set the status back to affected and nominate it for approval if you feel otherwise, however.