Crash in mozilla::AudioProxyThread::InternalProcessAudioChunk

RESOLVED FIXED in Firefox 55

Status

()

Core
WebRTC: Audio/Video
--
critical
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: philipp, Assigned: padenot)

Tracking

({crash, regression})

51 Branch
mozilla55
All
Windows 7
crash, regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 wontfix, firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
This bug was filed from the Socorro interface and is 
report bp-e7667c05-6902-49ce-b406-677120170603.
=============================================================
Crashing Thread (100)
Frame 	Module 	Signature 	Source
0 	xul.dll 	mozilla::AudioProxyThread::InternalProcessAudioChunk(int, mozilla::AudioChunk&, bool) 	media/webrtc/signaling/src/mediapipeline/MediaPipeline.cpp:552

this is a low volume crash signature that shows up from windows 7 users starting with firefox 51 and later builds.
most user comments say they where trying to join a facebook video call.

Comment 1

6 months ago
Paul can you please take a look and asses how important this is?
Component: WebRTC: Signaling → WebRTC: Audio/Video
Flags: needinfo?(padenot)
(Assignee)

Comment 2

6 months ago
Rare stack buffer overflow. Patch coming up.
Flags: needinfo?(padenot)
(Assignee)

Updated

6 months ago
Assignee: nobody → padenot
Comment hidden (mozreview-request)

Comment 4

6 months ago
mozreview-review
Comment on attachment 8874374 [details]
Bug 1369967 - Remove one use of a stack-allocated buffer and fix another buffer's size.

https://reviewboard.mozilla.org/r/145734/#review149712
Attachment #8874374 - Flags: review?(rjesup) → review+

Comment 5

6 months ago
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/7edfae1ee9dc
Remove one use of a stack-allocated buffer and fix another buffer's size. r=jesup
https://hg.mozilla.org/mozilla-central/rev/7edfae1ee9dc
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
This already missed 54 and it doesn't look high-volume enough on ESR52 to worry about backporting there either. Feel free to set the status back to affected and nominate it for approval if you feel otherwise, however.
status-firefox54: affected → wontfix
status-firefox-esr52: affected → wontfix
You need to log in before you can comment on or make changes to this bug.