1369992 - error: 'GetNative' is a protected member of 'mozilla::jni::NativeImpl<mozilla::java::CodecProxy::NativeCallbacks, mozilla::JavaCallbacksSupport>'

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Makoto Kato [:m_kato]]

When building Fennec using clang, the following build error occurs.

 0:17.02 /mozilla/mobile/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp:1099:27: error: 'GetNative' is a protected member of 'mozilla::jni::NativeImpl<mozilla::java::CodecProxy::NativeCallbacks, mozilla::JavaCallbacksSupport>'
 0:17.02     JavaCallbacksSupport::GetNative(mJavaCallbacks)->Cancel();
 0:17.02                           ^
 0:17.02 /mozilla/objdir-android/dist/include/mozilla/jni/Natives.h:821:18: note: declared protected here
 0:17.02     static Impl* GetNative(const typename Cls::LocalRef& instance) {
 0:17.02                  ^

We should define GetNative as public into JavaCallbacksSupport.h.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1369992 - Make GetNative as public for clang.

When building Fennec using clang, the following build error occurs.

 0:17.02 /mozilla/mobile/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp:1099:27: error: 'GetNative' is a protected member of 'mozilla::jni::NativeImpl<mozilla::java::CodecProxy::NativeCallbacks, mozilla::JavaCallbacksSupport>'
 0:17.02     JavaCallbacksSupport::GetNative(mJavaCallbacks)->Cancel();
 0:17.02                           ^
 0:17.02 /mozilla/objdir-android/dist/include/mozilla/jni/Natives.h:821:18: note: declared protected here
 0:17.02     static Impl* GetNative(const typename Cls::LocalRef& instance) {
 0:17.02                  ^

We should define GetNative as public into JavaCallbacksSupport.h.

Review commit: https://reviewboard.mozilla.org/r/145570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145570/

Comment 2

[Botond Ballo [:botond]]

(In reply to Makoto Kato [:m_kato] from comment #0)
> When building Fennec using clang

Out of curiosity, how do you build Fennec with clang?

Comment 3

[Makoto Kato [:m_kato]]

(In reply to Botond Ballo [:botond] from comment #2)
> (In reply to Makoto Kato [:m_kato] from comment #0)
> > When building Fennec using clang
> 
> Out of curiosity, how do you build Fennec with clang?

You need rebase a patch of bug 1288442, then set CC and CXX like the following.

CC="$HOME/android-ndk-r14b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang"
CXX="$HOME/android-ndk-r14b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++"
HOST_CC=clang
HOST_CXX=clang++

Comment 4

[John Lin [:jhlin][:jolin]]

Comment on attachment 8874106 [details]
Bug 1369992 - Make GetNative as public for clang.

https://reviewboard.mozilla.org/r/145570/#review149620

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff48915ee1d8
Make GetNative as public for clang. r=jolin

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff48915ee1d8