Closed Bug 1369992 Opened 3 years ago Closed 3 years ago

error: 'GetNative' is a protected member of 'mozilla::jni::NativeImpl<mozilla::java::CodecProxy::NativeCallbacks, mozilla::JavaCallbacksSupport>'

Categories

(Core :: Audio/Video: Playback, defect)

55 Branch
Unspecified
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

When building Fennec using clang, the following build error occurs.

 0:17.02 /mozilla/mobile/media/webrtc/signaling/src/media-conduit/WebrtcMediaCodecVP8VideoCodec.cpp:1099:27: error: 'GetNative' is a protected member of 'mozilla::jni::NativeImpl<mozilla::java::CodecProxy::NativeCallbacks, mozilla::JavaCallbacksSupport>'
 0:17.02     JavaCallbacksSupport::GetNative(mJavaCallbacks)->Cancel();
 0:17.02                           ^
 0:17.02 /mozilla/objdir-android/dist/include/mozilla/jni/Natives.h:821:18: note: declared protected here
 0:17.02     static Impl* GetNative(const typename Cls::LocalRef& instance) {
 0:17.02                  ^

We should define GetNative as public into JavaCallbacksSupport.h.
Blocks: 1163171
(In reply to Makoto Kato [:m_kato] from comment #0)
> When building Fennec using clang

Out of curiosity, how do you build Fennec with clang?
(In reply to Botond Ballo [:botond] from comment #2)
> (In reply to Makoto Kato [:m_kato] from comment #0)
> > When building Fennec using clang
> 
> Out of curiosity, how do you build Fennec with clang?

You need rebase a patch of bug 1288442, then set CC and CXX like the following.

CC="$HOME/android-ndk-r14b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang"
CXX="$HOME/android-ndk-r14b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++"
HOST_CC=clang
HOST_CXX=clang++
Comment on attachment 8874106 [details]
Bug 1369992 - Make GetNative as public for clang.

https://reviewboard.mozilla.org/r/145570/#review149620
Attachment #8874106 - Flags: review?(jolin) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/ff48915ee1d8
Make GetNative as public for clang. r=jolin
https://hg.mozilla.org/mozilla-central/rev/ff48915ee1d8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.