1370005 - Crash in mozilla::MozPromise<T>::ThenInternal

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-7c9ac719-764c-4b9a-b126-1fe920170603.
=============================================================

Seen while looking at crash stats - so far 8 crashes/7 installs: http://bit.ly/2rvDLFH. 1 crash also present in 53.0.3

Possible regression range based on build ID: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bdb2387396b4a74dfefb7c983733eed3625e906a&tochange=aeb3d0ca558f034cbef1c5a68bd07dd738611494

Comment 1

[Nicholas Nethercote [inactive]]

Gerald, any ideas?

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

https://hg.mozilla.org/mozilla-central/annotate/aeb3d0ca558f/dom/media/MediaFormatReader.cpp#l1975

decoder.mDecoder->Decode() calls InvokeAsyncImpl() which generates a new |PromiseType::Private|. I can't see how |mHaveRequest| is true for a newly created MozPromise.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Seeing 55 is going to beta soon, let's backout bug 1367679 to see if that mitigates the crash.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1370005. P1 - backout bug 1367679.

Review commit: https://reviewboard.mozilla.org/r/145668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145668/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8874318 [details]
Bug 1370005. P1 - backout bug 1367679.

https://reviewboard.mozilla.org/r/145668/#review149592

:-(

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

:( I will land bug 1367679 to 56 so we have more time debugging.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02b76f664ebb
P1 - backout bug 1367679. r=gerald

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

https://crash-stats.mozilla.com/signature/?version=55.0a1&signature=mozilla%3A%3AMozPromise%3CT%3E%3A%3AThenInternal&date=%3E%3D2017-05-05T06%3A31%3A47.000Z&date=%3C2017-06-05T06%3A31%3A47.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#correlations

(94.12% in signature vs 24.52% overall) Addon "[e-mail]" = true

what is this addon?

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Now I am quite sure bug 1367679 is innocent. We have bp-c1912aa5-f209-432c-83c4-81a700170603 even without bug 1367679.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/02b76f664ebb

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

This might be fixed on 55 in bug 1345342, but we'll have to check back in a couple of days to make sure.

Comment 12

[[:philipp]]

these crashes have gone away with the landing of bug 1370805