137005 - Change wording of "File as group" to "Bookmark this group of tabs"

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[jag (Peter Annema)]

Change wording of "File as group" to "Bookmark this group of tabs" in the "File
bookmark" dialog.

Comment 1

[jag (Peter Annema)]

Attachment: Change wording

Comment 2

[Joe Hewitt (gone)]

Comment on attachment 78808 [details] [diff] [review]
Change wording

sr=hewitt

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 78808 [details] [diff] [review]
Change wording

r=bryner

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 78808 [details] [diff] [review]
Change wording

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 5

[Paul Wyskoczka]

Need Lori Kaplan and Michelle Carlson to comment in this bug that they approve
the change for the mozilla1.0 branch before we can give adt1.0.0+

Comment 6

[scottputterman]

Jatin, Lori, and Michele, do you agree with this change?

Comment 7

[Michele Carlson]

Sorry we can't take any new UI changes at this point. Please check this change
in after the beta ships.
Sorry but if we take more changes we will not be able to ship our localized
versions simultaneously.

Comment 8

[Claudius Gayle]

<.02> to wear my techdoc hat for a sec I wanted to state that IMHO the wording
should be more like "Bookmark as a group of tabs" or "Create bookmark as a group
of tabs". To more clearly distinguish from the idea of simply filing several
individual bookmarks at once, where instead one is actually creating this new
entity called a 'group'.</.02>

Comment 9

[Jaime Rodriguez, Jr.]

adt1.0.0-/[ADT3 RTM]. Too far past L10N/UI freeze for beta. Pls check it into
the trunk.

Comment 10

[Jatin Billimoria]

I originally suggested "Bookmark this group of tabs" for the following reasons:

- If there are other windows open or other windows with tabs open, the use of
the word "this" indicates more clearly that only the tabs in this window are
being bookmarked.

- The UI makes it pretty clear that only one bookmark is being placed (the
greying out of the Location field when the checkbox is selected and the
placement of the triple bookmark icon).

Comment 11

[Peter Trudelle]

Mass moving nsbeta1+/adt3 bugs assigned to Navigator team engineers out to
target milestone 1.0.1.  Please confine your attentions to driving down our list
of TM 1.0 bugs for beta.  Better to help, debug, or test one of them than fix
one of these.

Comment 12

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 13

[scottputterman]

Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email [e-mail].  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.

Comment 14

[Yuting Kuo]

I suggest the setence "File all tabs as a group" as opposed to "Bookmark this
group of tabs" or the original "File as group".

Reason:
1. "Group" refers to a bookmark entry type. There is no "Group of tabs" concept
anywhere else in Mozilla.

2. "this" is not required, as it is clear which window you are working on. "All
tabs" should not make people think of "all tabs in all windows".

Comment 15

[jag (Peter Annema)]

I like it.

Jatin? Lori?

Comment 16

[Jatin Billimoria]

The current suggestions along with rebuttals:
Bookmark as a group of tabs: Doesn't take into account that the user may have
other windows with tabs.
Bookmark this group of tabs: Users may think several bookmarks are placed.
"Group of tabs" may be confusing.
File all tabs as a group: Doesn't take into account that the user may have other
windows with tabs.

After seeing the pitfalls of each of these wording, I suggest the following:
"Bookmark these tabs as a group"

Comment 17

[jag (Peter Annema)]

Fine by me.

Comment 18

[Evelyn Prime-MacAdam]

Agree as well:  "Bookmark these tabs as a group" sounds good.

Comment 19

[Evelyn Prime-MacAdam]

Slightly modified recommendation: "Bookmark these Navigator tabs as a group"

Comment 20

[Jatin Billimoria]

Evelyn's wording is more accurate and is fine by me.
Peter T has also given his OK to Evelyn's wording in Comment #19.

Comment 21

[jag (Peter Annema)]

nsbeta1- -> nsbeta1

Comment 22

[jag (Peter Annema)]

I think we had "Bookmark this group of tabs" on the board today.

Comment 23

[jag (Peter Annema)]

Comment on attachment 78808 [details] [diff] [review]
Change wording

Clearing has approval flag

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 78808 [details] [diff] [review]
Change wording

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 25

[Syd Logan]

adding nsbeta1+, adt1.0.1+ on behalf of ADT

Comment 26

[Michele Carlson]

l10n approved. Please check this into the branch by Weds.

Comment 27

[jag (Peter Annema)]

Was checked in on the trunk a while ago, now also checked in on the branch.

Comment 28

[Claudius Gayle]

Sigh. I thought we had a fine consensus of opinion in comment16 through
comment20. What happened?
Jag says we wrote the old way on the white board at some point after(comment22);
was Jatin in the room? Anyway, I'm too tired to fight and this'll never get
changed now anyway.

marking VERIFIED Fixed for 20020627 branch and trunk builds on all platforms.